Repository navigation
Set up a repository whose GitHub binding has no full name (0.3.18) - #30
Merged
Merged
Conversation
The backend returns an empty github_full_name for some GitHub repository bindings (6 of 46 on the local backend, binance-connectors among them), while their git_ssh_url is valid. Setup clones from git_ssh_url and never reads the full name, but parsing required it, so Set up locally failed with "GitHub binding GitHub full name is required." The full name is now optional: missing or empty is null, a multi-line value is still refused. The setup test uses the backend's real shape. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why "Set up locally" failed for Binance
The backend returns
github_full_name: ""for some GitHub repository bindings. On the local backend that is 6 of 46:binance-connectors,valmer-connectors,alpaca-connectors,MainSequenceMarkets,etfholdingextractorandxcontentcreation. Each of those bindings has a validgit_ssh_url.Setup clones from
git_ssh_urland never readsgithub_full_name, butgitHubRepositoryBindingFromResponserequired it, so setup stopped with "GitHub binding GitHub full name is required." No host reads the field either: only test fixtures in this repo, the Codex plugin and the VS Code extension set it.Change
github_full_nameis optional: missing or empty becomesnull, and a multi-line value is still refused. The type is nowstring | null.null, missing and present names.Verification
npm test: 190/190 pass, and typecheck passes. Both changed tests fail on the old parser.repositorySetupInfo, GET requests only) forbinance-connectorson the local backend:API_ERROR GitHub binding GitHub full name is required.main: ok, clones git@github.com:mainsequence-projects/binance-connectors.gitThe backend leaving the name empty for those bindings is a separate data issue; setup no longer depends on it.
🤖 Generated with Claude Code