Skip to content

Add JSON schema validation test suite#7

Open
billmallard wants to merge 3 commits into
makerplane:masterfrom
billmallard:master
Open

Add JSON schema validation test suite#7
billmallard wants to merge 3 commits into
makerplane:masterfrom
billmallard:master

Conversation

@billmallard
Copy link
Copy Markdown

Summary

  • Adds tests/test_canfix_spec.py — 30 pytest tests covering structural integrity of canfix.json
  • Tests validate top-level structure, all 230 parameter entries (required fields, IDs, types, min/max), 17 group ranges, and 10 status entries
  • Handles compound type notation (CHAR[2], INT[2],BYTE, DINT) and comma-formatted numbers ("60,000") present in the spec
  • All 30 tests pass against the current spec with zero modifications to production code

Test plan

  • cd tests && pip install pytest && pytest -v — all 30 tests should pass
  • Re-run after any spec edit to catch regressions in parameter structure

🤖 Generated with Claude Code

billmallard and others added 3 commits April 18, 2026 06:36
Validates canfix.json structural integrity: 230 parameters with
required fields, unique IDs in 256-1759 range, valid compound/array
types, parseable min/max with comma-formatted number handling,
group coverage of 0-2047, status entries, and known-parameter
spot checks.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant