Repository navigation
Remove the remaining invented 0 % / window values (VibeTV #289) - #16
Conversation
…Sub2API, MiniMax, Antigravity) - Antigravity: export NamedRateWindow.usage_known as usageKnown so an unknown lane is no longer read as a real 0 %. - OpenCode / OpenCode Go: a percent without resetInSec has no reset time instead of resets_at = now. - OpenCode Go local estimate: no usage in the last five hours means no session reset, not a made-up 5 h countdown. - Sub2API: the subscription expiry is an informational row, not a 0 % window whose reset is the contract end. - MiniMax: a coding-plan clock time that has passed rolls the parsed time by one day instead of becoming now + 1 day. Each item has a test that failed before; the explicit resetInSec: 0 case stays a reset (VibeTV nesszer#289 section C).
The dashboard window payload carried 0 % used / 100 % remaining for an informational primary and for an Antigravity lane without usage, with no way to tell them from a real zero. Add an additive `unavailable` key (omitted when false) and let the built-in web UI skip those rows (Marcus's P3 on #15, VibeTV nesszer#289).
|
Wir übernehmen alle fünf Punkte aus deinem Review (CodeBuddy, Warp, Kilo, MiMo, Manus) und zusätzlich die Funde unserer eigenen Prüfung (Codebuff, Devin, Doubao, Sub2API, Venice, Abacus, MiniMax u. a.). Bitte nicht pushen, bis wir "fertig ()" melden – wir pushen per Merge-Commit, kein Force-Push, und ziehen #17 danach nach. |
|
fertig (f327cfc), zurück an dich. Neuer Head von #16: Deine fünf Punkte
Zusätzlich aus unserer eigenen Prüfung (je ein Commit, je ein Test, der vor dem Fix rot war)
Geprüft: #17 ist per Merge-Commit nachgezogen ( |
marcus7989
left a comment
There was a problem hiding this comment.
W182 re-review: ohne Befund (no P1/P2 findings) on f327cfcbbce7c8ff21006f1681dfdd2bcb4f0e05, stacked on #15 (53941bcc). Rechecked the delta since W180 (b6668e29) against Paul's response.
All five W180 findings are correctly addressed: CodeBuddy retains 25/100 alongside a complete empty package, Warp Unlimited is informational and preserves a real bonus quota, and Kilo/MiMo/Manus retain observed balances without inventing percentages. The seven original independent probes (including the previously noted Abacus 0/0 case) now all pass. The 14 additional corrections are plausible; the 26 review16 regression tests pass, and the changed branches preserve explicit zero and independent measured windows while leaving absent resets absent.
The two deliberate deviations are reasonable: DeepInfra retains measured budget usage and puts suspension/debt in its text instead of turning it into a fabricated 100%; OpenCode Go local history exposes observed costs without asserting server quotas from constants. Native Companion presentation of this information remains part of the Windows check.
Local cargo test -p codexbar --jobs 2: 1991 passed, 4 failed, 1 ignored. The four failures are the known macOS Windows-path cases (pi_family x2, codex_sessions, hooks), matching W180's head/base evidence. cargo fmt --all --check and diff whitespace checks pass. This is a code review, not native Windows/UI validation or merge/tag approval; no devices were used.
… tokens (review #16) Kimi K2: a response with only cash_balance/voucher_balance is no longer an error; both amounts reach the informational extra windows. Doubao: an ambiguous request quota seen twice keeps the observed tokens as an informational result instead of an error. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
@marcus7989 A second review pass on the PR head 1. Kimi K2 drops real cash/voucher amounts when there is no main balance ( 2. Doubao loses the observed tokens when the request quota stays ambiguous ( Red tests (before the fix): Branch: Shall we push this onto the PR branch before you tag .15, or will you take it? |
|
We're taking over the push of our fix branch now (per your OK in VibeTV-shop/vibetv#284, 07:43) – please don't push to this branch until we report back. |
|
Joint Windows probe of #15–#17: PASS (details below; same text on all three PRs). Build: local merge branch
Ready for your merge, then tag |
|
Done ( |
|
W211 · Beelink Windows validation, 2026-10-29 · STOP (environment blocker) The exact native Rust 1.98.0 baseline/probe comparison could not start: HOMESTATION-WIN has no cargo/rustc/rustup on PATH, no user .cargo/.rustup directory, and no matching Rust/MSVC/Git executables in the checked tools/program directories. No compiler/toolchain was installed during this slot. This is an unfulfilled test environment, not an observed product regression; no cargo test exit codes exist and the known restart-test result remains unresolved. Task results: (1) baseline 7614e4d vs probe 8b8134d BLOCKED before execution; (2) isolated #15 / .14 build and VibeTV smoke NOT RUN; (3) automatic Windows Usage/Refresh NOT RUN after the explicit stop condition; (4) NO MERGES, NO TAGS, no release workflow triggered. Final baseline check passed: app 9999.0.2266, runtime a9e985be9d1500de8455edc26d62c9a66b52bd4f, VibeTV 5804558, Clippy, brightness 20, automatic codex/claude/cursor. All app files and 13/13 configs match the pre-slot backup byte-for-byte; Firefox process IDs and existing Codex CLI auth-file hash are unchanged. No login, reboot or OS switch performed. Current PR heads remain #15 53941bc, #16 cacb7c8, #17 0c5def4. Local evidence: .local/reports/wincb16/BEELINK-W211.md; w211/tools-result.json and w211/final-result.json. The next native run needs a prepared Rust 1.98.0/MSVC build environment, or a separately approved cross-build/native-execution plan; it must not be reported as already tested. |
Ziel
Windows-Kunden sehen für alle verbleibenden Provider „nicht verfügbar" statt erfundener 0 % / Fenster / Reset-Zeiten (VibeTV-shop/vibetv#289, Folge von nesszer#285 Schritt 1).
Regel: keine neue Provider-Bedeutung · eine echte 0/N bleibt ein Erfolg (je Provider ein Test) · fehlender Zähler oder fehlende Gesamtmenge → Provider-Fehler, oder
RateWindow::informational(...), wenn ein echtes zweites Fenster existiert · Guthaben/Kosten/Zähler ohne Nenner → informational. Jeder Fix hat einen roten Test davor.Bitte zuerst #15 mergen (dieser PR baut darauf auf, Basis ist
claude/missing-data-no-zero; nach dem Merge von #15 zieht GitHub die Basis nach).Was enthalten ist
usageKnown(NamedRateWindow); OpenCode/OpenCode Go: Reset nur, wenn die Quelle ihn nennt (keinnow + 0), lokale Schätzung ohne aktive Sitzung ohne Reset; Sub2API-Ablauf ist informational statt Quota-Fenster; MiniMax Coding Plan rollt die geparste Uhrzeit um einen Tag stattnow + 1 Tag.unavailable(ausis_informationalbzw.!usage_known);dashboard.htmlblendet solche Fenster aus. Echte 0 % bleibt sichtbar.Entscheidungen bei der Zusammenführung (bitte prüfen)
Tests
cargo test -p codexbar --lib --jobs 2: 1970 grün, 4 rot. Die 4 roten (pi_family_tests::config_dir_must_stay_within_home,…::windows_shims_and_paths_are_normalized_for_dialect,codex_sessions::tests::normalizes_codex_root_to_sessions_dir,core::hooks::tests::config_matching_respects_enabled_flag) sind Windows-Pfadtests auf macOS und schlagen auf der unveränderten Basis genauso fehl.cargo fmt --checksauber,git diff --checksauber. Clippy: keine Treffer in den geänderten Dateien (die übrigen Warnungen sind vorhandene Nicht-Windows-cfg-Warnungen).opencode/scraper.rsist toter Code und unverändert.Bitte an Marcus
Nach dem Review: mergen und
v0.60.3-vibetv.15als Prerelease taggen. Der VibeTV-Draft-PR mit dem Pin-Bump wartet darauf (SHA-256 kommt vom Release).🤖 Generated with Claude Code