Repository navigation
[K-Marcus] Add Copilot device login to CLI - #22
Draft
marcus7989 wants to merge 5 commits into
Draft
marcus7989 wants to merge 5 commits into
marcus7989 wants to merge 5 commits into
Conversation
Owner
Author
|
[K-Marcus] @codex review |
Owner
Author
|
[K-Marcus] @codex review |
Owner
Author
CodexBar's `serve` takes `--request-timeout`; here the option was rejected
and the server exited, so a caller had to leave it out on Windows.
The option now means what it means upstream: a request still unanswered
after that many seconds gets `504 Gateway Timeout` with
`{"error":"request timed out"}`. Its work is not stopped: a slow dashboard
snapshot finishes and is cached, so the next request is answered from it.
`0` waits without a deadline. Fractions are allowed, the cap is one day, a
negative value is an error.
One deliberate difference: upstream's default is 30 seconds, the default
here is 0. Without the option the server keeps waiting for slow providers
as it did before, so callers that do not pass it see no change.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit 370647c)
Owner
Author
|
@codex review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[K-Marcus] Add
config login --provider copilot --jsonfor the Windows engine used by VibeTV #343. The command emits the Mac-compatible device-code JSON line immediately, waits for GitHub authorization, then saves and activates the account in Win-CodexBar's existing protected token store. Existing GitHub accounts with the same identity are updated.Validation:
cargo test -p codexbar --lib cli::config(6 passed),cargo fmt --all -- --check,git diff --checkon macOS. Tests cover the JSON contract, no device-code disclosure, rejection of unsupported providers, account persistence, and preservation of another provider. No live OAuth or Windows/device test has been run.WinCB #6 also edits config.rs, but a local merge-tree against its current head had no conflict; #20 and #21 touch unrelated files. Draft pending Windows CI and a real sign-in/usage test; no merge or release requested.