Skip to content

fix: Restore Android ViewManager inheritance - #2055

Merged
mrousavy merged 3 commits into
mainfrom
mrousavy/fix-open-view-managers-main
Nov 9, 2026
Merged

mrousavy merged 3 commits into
mainfrom
mrousavy/fix-open-view-managers-main

Conversation

@mrousavy

@mrousavy mrousavy commented Nov 9, 2026 •

Copy link
Copy Markdown
Member

Restores open on generated Kotlin ViewManagers, fixing the regression from #1181 that undid #906. Includes regenerated bindings.

PaddedTestView forces native padding to 7. The shared pixel test checks the native default, React padding: 1, asymmetric updates, and padding removal, expecting 7 throughout. Android uses a custom setPadding override; Apple uses a UIView.frame override because UIKit has no padding setter.

The test passes on Android API 33 and iOS 27.0 on both main and v1. Confirmed the Apple test fails with the previous native implementation. Native builds, typechecking, lint, and formatting pass.

@vercel

vercel Bot commented Nov 9, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
nitro-docs Skipped Skipped Nov 9, 2026 3:33pm UTC

Request Review

@mrousavy
mrousavy merged commit 215c153 into main Nov 9, 2026
24 of 25 checks passed

This branch was previously deployed

1 inactive deployment
Preview — 61b72b1a Deployed Nov 9, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant