Repository navigation
perf: avoid boxing in Kotlin struct equality and hashing - #2057
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated Kotlin structs box primitive fields in
equals()and allocate a temporary object array inhashCode().Generate comparisons and hashes directly through shared helpers for arrays, doubles and nullable values. Other types use ordinary Kotlin equality and hashing. Initialize hashes from the first field and return its hash directly for single-field structs. Struct hash values change.
Validated with Nitrogen build/typecheck/lint and full spec regeneration. Kotlin regression checks passed 942 equality comparisons, 206 equal-value hash checks and 2,826 hash collection lookups across 28 generated structs. Primitive-only equality and hashing bytecode contains no boxing or temporary arrays.