fix(ios): evict stale FetchCache entries on barrier queue#72
Merged
riteshshukla04 merged 1 commit intoApr 11, 2026
Merged
Conversation
Avoid mutating results inside queue.sync read path; eviction runs async with .barrier and re-checks age to reduce races with concurrent readers. Made-with: Cursor
Collaborator
|
Thanks for the PR ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Compared to
main:FetchCache.getResultIfFreshno longer removes stale cache entries during a concurrent read (sync). Eviction runs on a barrier async block with a second age check so readers do not mutateresultsin the read path and races with refresh are reduced.What changes
queue.async(flags: .barrier)only if still stale.How to verify