Repository navigation
Conversation
|
@mfkrause is attempting to deploy a commit to the Margelo Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SkiaCameracan show the front camera preview upside down whenframe.isMirroredistrueandframe.orientationisleftorright.To reproduce, use
SkiaCamerawith the front camera on an iPhone. KeepenablePhysicalBufferRotationat its default value and immediately draw each camera frame to the canvas without any modifications. The issue occurs when a frame is both mirrored and rotated by 90掳 or 270掳.The renderer currently applies mirroring and rotation in the wrong order. This fix corrects that order.