Repository navigation
Fix core routing bugs and harden dependency injection - #2
Merged
Merged
Conversation
SamuelSchutz13
commented
Nov 9, 2026
Contributor
- Initialize Route::$inputBag so $request->all() works on static routes
- Only instantiate #[Route] attributes, ignore other method attributes
- Normalize leading/trailing slashes when matching routes
- URL-decode dynamic route parameters
- Resolve scalar/untyped constructor params via default or null, and throw a clear MareaTurboException instead of crashing
- Declare Request::$route instead of using dynamic properties
- Compute the accessed route once; guard missing CLI args
- Remove dead code (getUri, unused RouteParameters import)
- Add tests for all of the above
- Initialize Route::$inputBag so $request->all() works on static routes - Only instantiate #[Route] attributes, ignore other method attributes - Normalize leading/trailing slashes when matching routes - URL-decode dynamic route parameters - Resolve scalar/untyped constructor params via default or null, and throw a clear MareaTurboException instead of crashing - Declare Request::$route instead of using dynamic properties - Compute the accessed route once; guard missing CLI args - Remove dead code (getUri, unused RouteParameters import) - Add tests for all of the above Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
README: fix broken image and badge markup, add web server setup, parameter, DI, middleware ordering and matching-rule docs. Route attribute is now IS_REPEATABLE so one method can serve several routes, as documented. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.