Skip to content

Fix core routing bugs and harden dependency injection - #2

Merged
marriosdev merged 2 commits into
marriosdev:masterfrom
SamuelSchutz13:fix/core-bugs
Nov 12, 2026
Merged

marriosdev merged 2 commits into
marriosdev:masterfrom
SamuelSchutz13:fix/core-bugs

Conversation

@SamuelSchutz13

Copy link
Copy Markdown
Contributor
  • Initialize Route::$inputBag so $request->all() works on static routes
  • Only instantiate #[Route] attributes, ignore other method attributes
  • Normalize leading/trailing slashes when matching routes
  • URL-decode dynamic route parameters
  • Resolve scalar/untyped constructor params via default or null, and throw a clear MareaTurboException instead of crashing
  • Declare Request::$route instead of using dynamic properties
  • Compute the accessed route once; guard missing CLI args
  • Remove dead code (getUri, unused RouteParameters import)
  • Add tests for all of the above

SamuelSchutz13 and others added 2 commits November 9, 2026 08:45
- Initialize Route::$inputBag so $request->all() works on static routes
- Only instantiate #[Route] attributes, ignore other method attributes
- Normalize leading/trailing slashes when matching routes
- URL-decode dynamic route parameters
- Resolve scalar/untyped constructor params via default or null, and
  throw a clear MareaTurboException instead of crashing
- Declare Request::$route instead of using dynamic properties
- Compute the accessed route once; guard missing CLI args
- Remove dead code (getUri, unused RouteParameters import)
- Add tests for all of the above

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
README: fix broken image and badge markup, add web server setup,
parameter, DI, middleware ordering and matching-rule docs.
Route attribute is now IS_REPEATABLE so one method can serve
several routes, as documented.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@marriosdev
marriosdev merged commit 6e558a4 into marriosdev:master Nov 12, 2026
1 check failed
@marriosdev

Copy link
Copy Markdown
Owner

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants