Escape percent sign in translation#257
Open
sgiehl wants to merge 1 commit into
Open
Conversation
| "AlertDescriptionOptional": "Description (optional)", | ||
| "AlertDescriptionInlineHelp": "Enter a description to provide additional context, such as the purpose or usage.", | ||
| "AlertDescriptionPlaceholder": "Alert me when visits decrease by 40%", | ||
| "AlertDescriptionPlaceholder": "Alert me when visits decrease by 40%%", |
Contributor
There was a problem hiding this comment.
@sgiehl We don't need to create a new key here ?
Its already translated in other languages
Member
Author
There was a problem hiding this comment.
No. I'll fix the translations on weblate after the update
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We should always escape percent signs in translations, to ensure they won't break the
sprintfNote: This currently let's core tests for translations fail: matomo-org/matomo#24576
Checklist