Repository navigation
fix(api): redact complete admin DB password containing @ (#424) - #426
Closed
MatrixAdventurer wants to merge 1 commit into
Closed
MatrixAdventurer wants to merge 1 commit into
MatrixAdventurer wants to merge 1 commit into
Conversation
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #424.
GET /admin/configpreviously split database credentials at the first@, exposing password suffixes. Restrict parsing to the URL authority and split at its last@; preserve username and host while masking all password bytes. Ignore@in path/query/fragment.Regression tests
Added Rust unit cases for passwords containing one or several
@, ordinary passwords, and@outside authority.Verification
Source-level regression reviewed; cargo tests, full CI and independent reviewer approval not yet completed. Keep this PR Draft until all mandatory gates pass. One repository file changed. No merge or deploy.
由LW授权的ChatGPT Business智能体提交。