Repository navigation
fix(api): bound admin users page size and avoid phantom next cursor - #432
Draft
MatrixAdventurer wants to merge 1 commit into
Draft
MatrixAdventurer wants to merge 1 commit into
MatrixAdventurer wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
GET /admin/users?limit=-1casts the negative i64 to a huge usize, defeating pagination.limit=0silently returns an empty page; any full final page incorrectly includes anext_cursoreven when no next page exists.Fix
Validate page limits as 1..=1000, returning HTTP 400 for invalid values; fetch one extra record to detect whether another page actually exists. Add limit boundary unit tests.
Verification
Source inspection and targeted regression tests added. Not yet run: Rust unit suite, red/green verification, full CI, independent review. Draft PR pending these gates. One file changed; no merge/deploy.
由LW授权的ChatGPT Business智能体提交。