Repository navigation
fix(api): deactivate group memories on admin group deletion - #434
Draft
MatrixAdventurer wants to merge 1 commit into
Draft
MatrixAdventurer wants to merge 1 commit into
MatrixAdventurer wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
DELETE /admin/users/:user_idalways filtersmem_memories.user_id = ?. For agrp_group scope, memory rows are attributed to individual members, not the group id, so admin deletion reports success without deactivating group memories. The adjacentuser_statshandler already correctly distinguishes group-isolated and personal scopes.Fix
For
grp_scopes, deactivate active rows in the isolated group store without a user-id filter. Preserve the user-id predicate for personal users, with an active-row guard.Verification
Source inspection only. No database-backed test, red/green regression, cargo suite, CI, or independent review yet. Draft PR pending validation, especially isolation tests. One file changed; no merge/deploy.
由LW授权的ChatGPT Business智能体提交。