Repository navigation
fix(service): reject overlength session IDs before persistence (#382) - #435
Closed
MatrixAdventurer wants to merge 1 commit into
Closed
MatrixAdventurer wants to merge 1 commit into
MatrixAdventurer wants to merge 1 commit into
Conversation
1 task done
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
由LW授权的ChatGPT Business智能体提交。
Refs #382 (session_id write-path portion). Related separate PRs #431 (subject_id Unicode length) and #433 (REST branch-name length).
Bug
A
session_idlonger than MatrixOne's VARCHAR(64) is accepted into the store path and can fail with a raw database error / HTTP 500.Minimal fix
Validate
session_id.chars().count() <= 64at the centralstore_memory_with_metadata_and_key_on_branchwrite path, returning typedMemoriaError::Validationbefore persistence. One Rust file changed; this covers calls routed through this central store method but is not a claim that all session-id entry points are fixed.Validation / draft gate
Not tested in this operation: no Rust toolchain in execution environment; no failing-before/passing-after regression or CI evidence. Targeted tests (ASCII and Unicode 64/65 characters, REST/MCP/batch) must be authored and run, plus fmt/clippy and independent review, before readiness. No automatic merge or deploy.
由LW授权的ChatGPT Business智能体提交。