Repository navigation
fix(service): reject future observed_at timestamps (#380) - #438
Draft
MatrixAdventurer wants to merge 1 commit into
Draft
MatrixAdventurer wants to merge 1 commit into
MatrixAdventurer wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Partial fix for #380. Future
observed_atvalues can make memory age negative and distort recency scoring.initial_confidenceis handled separately in PR #437; this PR avoids duplicating that change.Fix
Reject future
observed_atbefore the service persists a memory. Add a unit test for past, absent, and future timestamps. One source file changed.Verification
Source inspection and regression test added; Rust toolchain unavailable in the execution sandbox. Unit test execution, red/green verification, CI and independent review not yet complete. Draft PR; no merge/deploy.
由LW授权的ChatGPT Business智能体提交。