Skip to content

[codex] fix security alerts #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maxatwork merged 2 commits into from
Mar 27, 2026
Merged

[codex] fix security alerts #104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ebac489
fix: resolve dependency security alerts
maxatwork Mar 27, 2026
0564395
fix: align CI with docs toolchain
maxatwork Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
strategy:
fail-fast: false
matrix:
node-version: [18, 20, 22]
node-version: [22.14.0]
Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai bot Mar 27, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: CI no longer tests the minimum supported Node version (18), which can let runtime compatibility regressions ship despite node@>=18 support.

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. At .github/workflows/ci.yml, line 19:

<comment>CI no longer tests the minimum supported Node version (18), which can let runtime compatibility regressions ship despite `node@>=18` support.</comment>

<file context>
@@ -16,7 +16,7 @@ jobs:
       fail-fast: false
       matrix:
-        node-version: [18, 20, 22]
+        node-version: [22.14.0]
 
     steps:
</file context>
Suggested change
node-version: [22.14.0]
node-version: [18, 22.14.0]
Fix with Cubic


steps:
- name: Checkout
Expand Down Expand Up @@ -47,7 +47,7 @@ jobs:
run: npm run pack:dry-run

docs-e2e:
name: docs-e2e (node 20)
name: docs-e2e (node 22.14.0)
runs-on: ubuntu-latest

steps:
Expand All @@ -57,7 +57,7 @@ jobs:
- name: Setup Node
uses: actions/setup-node@v4
with:
node-version: 20
node-version: 22.14.0
cache: npm

- name: Install
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pages.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ jobs:
- name: Setup Node
uses: actions/setup-node@v4
with:
node-version: 20
node-version: 22.14.0
cache: npm

- name: Install
Expand Down
9 changes: 4 additions & 5 deletions apps/docs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,30 +9,29 @@
"test": "vitest run",
"test:e2e": "playwright test",
"lint": "eslint \"src/**/*.{ts,tsx}\" \"test/**/*.{ts,tsx}\" \"test-e2e/**/*.ts\"",
"typecheck": "astro check",
"typecheck": "astro sync && tsc --noEmit",
"clean": "rimraf dist .astro"
},
"dependencies": {
"@astrojs/react": "^5.0.2",
"@form2js/core": "3.4.0",
"@form2js/dom": "3.4.0",
"@form2js/form-data": "3.4.0",
"@form2js/jquery": "3.4.0",
"@form2js/js2form": "3.4.0",
"@form2js/react": "3.4.0",
"@astrojs/react": "^4.4.0",
"astro": "^5.7.0",
"astro": "^6.1.1",
"jquery": "^3.7.1",
"rehype-stringify": "^10.0.1",
"react": "^19.1.1",
"react-dom": "^19.1.1",
"rehype-stringify": "^10.0.1",
"remark-gfm": "^4.0.1",
"remark-parse": "^11.0.0",
"remark-rehype": "^11.1.2",
"unified": "^11.0.5",
"zod": "^4.1.5"
},
"devDependencies": {
"@astrojs/check": "^0.9.4",
"@playwright/test": "^1.54.2",
"@types/jquery": "^3.5.33",
"@types/react": "^19.1.12",
Expand Down
6 changes: 2 additions & 4 deletions apps/docs/test/playground-shell.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,12 +136,11 @@ declare global {

let container: HTMLDivElement;
let root: ReturnType<typeof createRoot>;
let consoleErrorSpy: ReturnType<typeof vi.spyOn>;

beforeEach(() => {
globalThis.IS_REACT_ACT_ENVIRONMENT = true;
resetMockVariants();
consoleErrorSpy = vi.spyOn(console, "error").mockImplementation(() => undefined);
vi.spyOn(console, "error").mockImplementation(() => undefined);
container = document.createElement("div");
document.body.append(container);
root = createRoot(container);
Expand All @@ -154,8 +153,7 @@ afterEach(() => {
});
container.remove();
resetMockVariants();
consoleErrorSpy.mockRestore();
vi.clearAllMocks();
vi.restoreAllMocks();
});

function renderShell(): void {
Expand Down
Loading
Loading