Skip to content

feat: improve lyrics translation, subtitle generation, and settings s… - #2862

Open
rraattrruuee wants to merge 1 commit into
maxrave-dev:devfrom
rraattrruuee:feat/lyrics-subtitles-settings-improvement
Open

rraattrruuee wants to merge 1 commit into
maxrave-dev:devfrom
rraattrruuee:feat/lyrics-subtitles-settings-improvement

Conversation

@rraattrruuee

Copy link
Copy Markdown

What & why

This PR brings several improvements and fixes to lyrics, subtitles, settings, and voice/AI assistant workflows:

  1. Instant Lyrics Translation (French & all supported languages):

    • Migrated translation service to secure POST requests to resolve HTTP 403 errors and URL length constraints with translation providers (Google Translate & MyMemory).
    • Added an on-demand "Translate lyrics" button in FullscreenLyricsContent.
    • Added line-index fallback in LyricsView to prevent dropping translated lines when line timestamps drift.
  2. YouTube Subtitle Fetch & Multi-Source Fallback:

    • Integrated the VISIONOS InnerTube client context in YouTube.kt to bypass recent bot-checks/missing PO-token restrictions on timedtext URLs (exp=xpe).
    • Implemented an automatic cascade fallback in fetchOrGenerateSubtitles(): when YouTube lacks captions for independent tracks, it queries SimpMusic, LRCLIB, BetterLyrics, and Spotify.
  3. Settings Search Bar & Real-Time Filtering:

    • Replaced synchronous runBlocking calls on the UI thread with a non-blocking LaunchedEffect cache (mutableStateMapOf), enabling instant and fluid real-time search filtering across all setting sections and options.
  4. Expanded Romanization & Transcription Languages:

    • Added romanization support for Kazakh (KAZAKH), Mongolian (MONGOLIAN), Greek (GREEK with ELOT 743 / ISO 843), and Georgian (GEORGIAN with Mkhedruli).
    • Added corresponding configuration options in SettingScreen.
  5. AI & Voice Assistant Actions:

    • Declared orchestration actions in AiMusicAction and wired them through SharedViewModel (play recommendations, downloaded songs, favorites, cache, search & play, and playback controls).

Linked issue

Closes #

Checklist

  • This PR addresses an accepted issue (linked above)
  • I wrote or personally reviewed every line of this change
  • I tested it on Android and/or Desktop (say which, and how)
    • Tested on Android (Google Pixel 10 Pro): tested settings search filtering, French lyrics translation, subtitle generation on YouTube tracks, and romanization languages.

@rraattrruuee
rraattrruuee force-pushed the feat/lyrics-subtitles-settings-improvement branch from 59f46b3 to 3246478 Compare November 11, 2026 21:14
@rraattrruuee
rraattrruuee force-pushed the feat/lyrics-subtitles-settings-improvement branch from 3246478 to c8dab21 Compare November 12, 2026 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant