Skip to content

fix(desktop): fit the window and shell to a MacBook screen - #2883

Open
PhamThanhTu612002 wants to merge 3 commits into
maxrave-dev:devfrom
PhamThanhTu612002:fix/desktop-macbook-window
Open

PhamThanhTu612002 wants to merge 3 commits into
maxrave-dev:devfrom
PhamThanhTu612002:fix/desktop-macbook-window

Conversation

@PhamThanhTu612002

Copy link
Copy Markdown

Window: it opened off-centre and past the screen edges. The minimum size was multiplied by the display scale, but AWT sizes are already in points, so Retina turned 900x560 into 1800x1120, larger than the screen, and AWT grew the window to it. The minimum is now 900x560, the opening size is 85% of the usable area, and the position is centred.

Green button: it only zoomed to the usable area. macOS native full screen does not resize a borderless window, so the window is sized to the screen from code instead (MacFillScreen), with the menu bar and Dock hidden through NSApplication presentationOptions. Double-clicking the title bar still zooms. Corners are square while the window touches the screen edges.

Shell: on a narrow window the sidebar folds on its own without rewriting the stored preference, the side Now Playing panel yields to the fullscreen player below 960dp and keeps a floor for the content beside it, and the floating mini player capsule shrinks with the window instead of spilling past the sidebar edge.

What & why

Linked issue

Closes #

Checklist

  • This PR addresses an accepted issue (linked above)
  • I wrote or personally reviewed every line of this change
  • I tested it on Android and/or Desktop (say which, and how)

Window: it opened off-centre and past the screen edges. The minimum size was multiplied by the
display scale, but AWT sizes are already in points, so Retina turned 900x560 into 1800x1120, larger
than the screen, and AWT grew the window to it. The minimum is now 900x560, the opening size is 85%
of the usable area, and the position is centred.

Green button: it only zoomed to the usable area. macOS native full screen does not resize a
borderless window, so the window is sized to the screen from code instead (MacFillScreen), with the
menu bar and Dock hidden through NSApplication presentationOptions. Double-clicking the title bar
still zooms. Corners are square while the window touches the screen edges.

Shell: on a narrow window the sidebar folds on its own without rewriting the stored preference, the
side Now Playing panel yields to the fullscreen player below 960dp and keeps a floor for the content
beside it, and the floating mini player capsule shrinks with the window instead of spilling past the
sidebar edge.
@github-actions

Copy link
Copy Markdown

Thanks for the PR! Please complete the pull request template — in particular the checkbox confirming you wrote or personally reviewed every line, and the issue this change addresses. It helps us tell real contributions from the flood of auto-generated ones. Edit your PR description; no need to open a new PR.

@github-actions github-actions Bot added the needs-template PR template incomplete — see the triage comment label Nov 14, 2026
Pham Thanh Tu and others added 2 commits November 15, 2026 13:37
Playback menu: play/pause, next, previous, shuffle, repeat, like.
Window menu: mini player, hide window (Cmd+W keeps the music playing).
Space and the arrow keys stay unbound so text fields keep them.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
… hide

Minimise through NSWindow miniaturize: so a zoomed window is not un-zoomed first.
Remember the window frame and zoom state and put them back after a minimise or a hide
to the tray, and give the menu bar and Dock back while the window is out of sight.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-template PR template incomplete — see the triage comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant