Repository navigation
fix(desktop): fit the window and shell to a MacBook screen - #2883
Open
PhamThanhTu612002 wants to merge 3 commits into
Open
PhamThanhTu612002 wants to merge 3 commits into
PhamThanhTu612002 wants to merge 3 commits into
Conversation
Window: it opened off-centre and past the screen edges. The minimum size was multiplied by the display scale, but AWT sizes are already in points, so Retina turned 900x560 into 1800x1120, larger than the screen, and AWT grew the window to it. The minimum is now 900x560, the opening size is 85% of the usable area, and the position is centred. Green button: it only zoomed to the usable area. macOS native full screen does not resize a borderless window, so the window is sized to the screen from code instead (MacFillScreen), with the menu bar and Dock hidden through NSApplication presentationOptions. Double-clicking the title bar still zooms. Corners are square while the window touches the screen edges. Shell: on a narrow window the sidebar folds on its own without rewriting the stored preference, the side Now Playing panel yields to the fullscreen player below 960dp and keeps a floor for the content beside it, and the floating mini player capsule shrinks with the window instead of spilling past the sidebar edge.
|
Thanks for the PR! Please complete the pull request template — in particular the checkbox confirming you wrote or personally reviewed every line, and the issue this change addresses. It helps us tell real contributions from the flood of auto-generated ones. Edit your PR description; no need to open a new PR. |
Playback menu: play/pause, next, previous, shuffle, repeat, like. Window menu: mini player, hide window (Cmd+W keeps the music playing). Space and the arrow keys stay unbound so text fields keep them. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
… hide Minimise through NSWindow miniaturize: so a zoomed window is not un-zoomed first. Remember the window frame and zoom state and put them back after a minimise or a hide to the tray, and give the menu bar and Dock back while the window is out of sight. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Window: it opened off-centre and past the screen edges. The minimum size was multiplied by the display scale, but AWT sizes are already in points, so Retina turned 900x560 into 1800x1120, larger than the screen, and AWT grew the window to it. The minimum is now 900x560, the opening size is 85% of the usable area, and the position is centred.
Green button: it only zoomed to the usable area. macOS native full screen does not resize a borderless window, so the window is sized to the screen from code instead (MacFillScreen), with the menu bar and Dock hidden through NSApplication presentationOptions. Double-clicking the title bar still zooms. Corners are square while the window touches the screen edges.
Shell: on a narrow window the sidebar folds on its own without rewriting the stored preference, the side Now Playing panel yields to the fullscreen player below 960dp and keeps a floor for the content beside it, and the floating mini player capsule shrinks with the window instead of spilling past the sidebar edge.
What & why
Linked issue
Closes #
Checklist