Skip to content

Fix edge case where NaNs were at the end of the profile_number array. #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MBARIMike merged 2 commits into from
May 29, 2026
Merged

Fix edge case where NaNs were at the end of the profile_number array. #191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
190f5e1
Fix edge case where NaNs were at the end of the profile_number array.
MBARIMike May 29, 2026
acf0e4b
Update EXPECTED_SIZE_GITHUB, again.
MBARIMike May 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .vscode/launch.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -503,9 +503,9 @@
// Test a month with fewer plots to make
//"args": ["--auv_name", "daphne", "--start", "20260101", "--end", "20260131", "-v", "2", "--clobber"]
// Test pyxis and cbit_amphoursused plot
//"args": ["--auv_name", "pyxis", "--start", "20260501", "--end", "20260531", "-v", "1", "--clobber"]
"args": ["--auv_name", "pyxis", "--start", "20260526", "--end", "20260531", "-v", "1", "--clobber"]
// Test --current_month
"args": ["--current_month", "-v", "1"]
//"args": ["--current_month", "-v", "1"]
// Test reading downwelling_photosynthetic
// _photon_flux_in_sea_water from the root group of the netCDF file instead of the instrument group, which was the case for some early daphne log files
//"args": ["--auv_name", "daphne", "--start", "20260501", "--end", "20260531", "-v", "1", "--clobber"]
Expand Down
2 changes: 1 addition & 1 deletion src/data/create_products.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1074,7 +1074,7 @@ def _grid_dims(self, plot_vars: list[str] | None = None) -> tuple:
idist = np.linspace(
distnav.to_numpy()[0],
distnav.to_numpy()[-1],
int(3 * self.ds["profile_number"].to_numpy()[-1]),
int(3 * np.nanmax(self.ds["profile_number"].to_numpy())),
)
# Vertical gridded to .5 m, rounded down to nearest 10m (minimum 10m)
# Use only depths where at least one sensor variable has valid data to
Expand Down
2 changes: 1 addition & 1 deletion src/data/test_process_i2map.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ def test_process_i2map(complete_i2map_processing):
# but it will alert us if a code change unexpectedly changes the file size.
# If code changes are expected to change the file size then we should
# update the expected size here.
EXPECTED_SIZE_GITHUB = 63128
EXPECTED_SIZE_GITHUB = 63136
EXPECTED_SIZE_ACT = 63106
EXPECTED_SIZE_LOCAL = 64650
if str(proc.args.base_path).startswith("/home/runner"):
Expand Down
Loading