Skip to content

docs(adr): Ratify GH canvas ADRs - #338

Merged
mbeacom merged 2 commits into
mainfrom
ratify-gh-canvas-adrs
Nov 1, 2026
Merged

mbeacom merged 2 commits into
mainfrom
ratify-gh-canvas-adrs

Conversation

@mbeacom

@mbeacom mbeacom commented Nov 1, 2026

Copy link
Copy Markdown
Owner

The goal of this PR is to ratify outstanding canvas and extension related ADRs following rung-0 and 1 validation.

@mbeacom mbeacom self-assigned this Nov 1, 2026
Copilot AI balanced review requested due to automatic review settings November 1, 2026 17:42
Signed-off-by: Mark Beacom <m@beacom.dev>
@mbeacom
mbeacom force-pushed the ratify-gh-canvas-adrs branch from 4af79e9 to 6fa4b5a Compare November 1, 2026 17:43
@mbeacom
mbeacom enabled auto-merge (squash) November 1, 2026 17:46

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The ADR status changes leave MANIFEST.md stale, which will fail CI’s regeneration check, while status statements and amendment references remain inconsistent.

4 open issues
What changed in this PR

Ratifies six architecture decisions covering adrkit’s canvases, extension tools, session hooks, and review commands. This changes governance metadata only; no runtime behavior changes.

Changes:

  • Changes ADR-0047–0052 from proposed to accepted.
  • Adds the ratifying maintainer and decision timestamp to each record.

Decision compliance was not verified through the adrkit MCP server because it was unavailable.

File Description
docs/​adr/​0052-record-review-from-the-decision-board-only-after-the-host-s-own-confirmation.md Ratifies host-confirmed board review writes.
docs/​adr/​0051-record-review-state-with-adr-approve-adr-object-and-adr-resolve.md Ratifies CLI review-state commands.
docs/​adr/​0050-ship-a-read-only-decision-board-canvas-that-maps-the-corpus-from-adr-graph-and-a.md Ratifies the decision-board canvas.
docs/​adr/​0049-add-advisory-session-hooks-that-never-block-to-the-portable-agent-plugin.md Ratifies advisory session hooks.
docs/​adr/​0048-supply-read-only-adrkit-tools-to-github-copilot-through-the-plugin-extension-ins.md Ratifies read-only extension tools.
docs/​adr/​0047-show-provenance-review-cost-and-a-read-only-proposal-queue-in-the-decision-revie.md Ratifies canvas provenance, review-cost, and queue features.

Review effort: Balanced

@mbeacom
mbeacom disabled auto-merge November 1, 2026 17:48
…notes on ADR-0028 and ADR-0050

Updates the six status banners and ratification items to match the
accepted frontmatter, and regenerates MANIFEST.md with emit:manifest.

Adds the two reciprocal notes ratification called for: ADR-0048's
read-only extension tools on ADR-0028 (still no .mcp.json), and
ADR-0052's host-confirmed review writes on ADR-0050, both after its
banner and inside clause 1, which the amendment now qualifies.

Amendment notes naming these records drop "(proposed)", following the
ADR-0046 note on ADR-0045. Current-status mentions in AGENTS.md, the
plugin and CLI READMEs, the site's commands page, and the plugin
verification doc now say accepted. Evidence rungs and unmeasured-host
statements are unchanged.

Signed-off-by: Mark Beacom <m@beacom.dev>
@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown

Decisions governing this change

18 accepted decisions govern this change

Show all 18 governing decisions and why each applies
  • 0001 — Record architecture decisions as versioned markdown in git
    • via path: docs/adr/**
  • 0003 — Ship as a Spec Kit extension plus a standalone CLI, not a competing harness
    • via path: packages/cli/**
  • 0007 — Isolate integrations as optional adapters and build only against public surfaces
    • via path: packages/adapters/**
  • 0011 — Host the canonical JSON Schema at its $id on adrkit.dev
    • via path: site/**
  • 0028 — Ship decision memory as a portable agent plugin, and omit the MCP wiring hosts cannot honor
    • via path: packages/adapters/agent-plugin/**
  • 0030 — Keep extension surfaces that carry a dependency tree outside this repository
    • via path: packages/adapters/**
  • 0033 — Select interactive graph presentation at the CLI boundary while preserving piped DOT
    • via path: site/src/content/docs/**
  • 0034 — Extend the portable agent plugin with decision backfill
    • via path: docs/reference-verification-agent-plugin.md
    • via path: packages/adapters/agent-plugin/**
  • 0037 — Treat generated knowledge systems as downstream read models, not decision authorities
    • via path: site/src/content/docs/**
  • 0038 — Offer the bootstrap decision record as an offer rather than a backfill candidate
    • via path: docs/reference-verification-agent-plugin.md
    • via path: packages/adapters/agent-plugin/**
  • 0039 — Derive a valid-time window from date and supersession, and resolve a git ref at the CLI boundary
    • via path: site/src/content/docs/commands.mdx
  • 0040 — Keep derived surfaces in lockstep with three mechanisms matched to three classes of drift
    • via path: AGENTS.md
    • via path: MANIFEST.md
  • 0045 — Ship an advisory adr-review dynamic workflow in the portable agent plugin
    • via path: docs/reference-verification-agent-plugin.md
  • 0046 — Ship a read-only decision-review canvas for the GitHub Copilot app in the portable agent plugin
    • via path: docs/reference-verification-agent-plugin.md
  • 0047 — Show provenance, review cost, and a read-only proposal queue in the decision-review canvas
    • via path: docs/reference-verification-agent-plugin.md
  • 0048 — Supply read-only adrkit tools to GitHub Copilot through the plugin extension instead of MCP wiring
    • via path: docs/reference-verification-agent-plugin.md
  • 0049 — Add advisory session hooks that never block to the portable agent plugin
    • via path: docs/reference-verification-agent-plugin.md
  • 0050 — Ship a read-only decision-board canvas that maps the corpus from adr graph and adr queue
    • via path: docs/reference-verification-agent-plugin.md

Links point at 8df3109, this run's GITHUB_SHA. Run adr explain <path> locally to see why a file is governed.

@mbeacom
mbeacom merged commit 9513165 into main Nov 1, 2026
17 checks passed
@mbeacom
mbeacom deleted the ratify-gh-canvas-adrs branch November 1, 2026 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants