Repository navigation
Conversation
… advisory surface Proposes GitHub Agentic Workflows shared components under packages/adapters/gh-aw/ as an advisory distribution surface for the decision review, staged until calibrated per ADR-0027. The decision is conditional on the spike in mbeacom/adrkit-demo#9; two of its four load-bearing measurements are in, and the record lists the rest as action items. Signed-off-by: Mark Beacom <m@beacom.dev>
Decisions governing this change2 accepted decisions govern this change
Links point at |
There was a problem hiding this comment.
🟡 Changes recommended
The proposed gate can silently skip unresolved review inputs, and the ADR overstates containment of a PR-modifiable workflow that can publish required check contexts.
2 open issues
What changed in this PR
Proposes ADR-0061 for an independently versioned GitHub Agentic Workflows adapter that would extend adrkit’s advisory decision review into CI. This is documentation only; the proposal remains conditional and unratified.
Changes:
- Defines component placement, version pins, default capabilities, output restrictions, and the deterministic activation gate.
- Establishes staged defaults, calibration thresholds, spike evidence, and remaining validation work.
- Regenerates the manifest to include ADR-0061 and update corpus totals.
Full ADR compliance was not verified; the adrkit MCP server was unavailable.
| File | Description |
|---|---|
MANIFEST.md |
Updates the generated inventory to 60 records and adds proposed ADR-0061. |
docs/adr/0061-ship-github-agentic-workflows-shared-components-as-an-advisory-distribution-surf.md |
Proposes the gh-aw distribution surface, safeguards, calibration requirements, and ratification conditions. |
Review effort: Balanced
| `governs=true` only when lint exits `0`, check exits `0` or `1`, and | ||
| `.governing | length > 0`; otherwise `governs=false`. When lint or check | ||
| cannot complete, the step writes `unverified` with the exit code to the job | ||
| summary instead of skipping silently (ADR-0038). The agent job runs only on |
There was a problem hiding this comment.
Agreed, and confirmed against the code: check builds no snapshots, so package/entity matchers come back affects-unresolvable at info, and a capped marker scan leaves ok true. Fixed in b6a68c0. Clause 6 now writes partial to the job summary, with the inert record ids and the cap counts, whenever affects-unresolvable, marker-scan-capped, or marker-declarations-capped appears. It keys on those rule ids, not on severity. governs still follows .governing, so the exit-code contract doesn't change. Gate fixtures for each case are listed as tests to land, and the spike rebuild (action item 3) picks the check up too.
| It is advisory under ADR-0035: never a required check, so a same-repo PR that | ||
| edits its own workflow (fact 7) can at most change advisory output on its own | ||
| PR. The governing-decisions Action remains the CI authority (ADR-0045), and |
There was a problem hiding this comment.
Right, the containment sentence overclaimed. Required checks match by name, and a PR that edits the job can use checks: write to publish any name. Fixed in b6a68c0. Clause 8 now states that residual risk and names workflow-path protection as the real control (ADR-0042 here). It also requires the consumer docs to ask for an equivalent ruleset or code-owner review on .github/workflows/**. I added it to Trade-offs as well.
…-0061 adr check passes no dependency or catalog snapshot and caps marker scans without changing ok, so the gate now writes partial to the job summary on affects-unresolvable, marker-scan-capped, or marker-declarations-capped, keyed on rule ids. Clause 8 drops the claim that an advisory check confines a PR that edits its own workflow: checks: write can publish any check name, so the record states the residual risk and requires workflow-path protection in consumer docs. Signed-off-by: Mark Beacom <m@beacom.dev>
Adds fact 9: the spike rebuilt without the MCP server or the plugin reached the same four verdicts, cited real record filenames, and posted nothing, at a median 8.35 agent credits against 8.11 before. The cost baseline moves to 8.35 (threshold 16.7), action item 3 is done, and the partial-gate path is listed as unexercised because the demo corpus has no package or entity matcher. Signed-off-by: Mark Beacom <m@beacom.dev>

I'm proposing ADR-0061: ship adrkit's decision review as a set of GitHub Agentic Workflows (gh-aw) shared components. Adopting it would take one
imports:line plus a pinned CLI and image. The model-backed review would run inside gh-aw's sandbox and firewall and spend gh-aw's AI credits, and it stays staged until calibrated, as ADR-0027 requires.The record is
proposedand conditional. Nothing underpackages/adapters/gh-aw/exists yet, and none should until it is ratified.What the record decides
packages/adapters/gh-aw/, versioned independently (ADR-0007, ADR-0030) on agh-aw-v<semver>tag. The image is pinned by digest and the CLI and gh-aw compiler by exact version. CI diffs the compiled lock.adr check --json, and a read-only checkout. The MCP server and the agent plugin are opt-in and off by default.neutral. Every verb that approves, requests changes, merges, labels or opens an issue is forbidden.adr lintruns, thenadr check. The agent runs only when something governs the change, and the gate fails closed tounverified.pull_requestonly, with no fork opt-in, and is never a required check.Evidence so far (rung 1, plus a partial rung-2 smoke)
The spike is mbeacom/adrkit-demo#9, compiled with gh-aw v1.0.1
--strict.What is still open, listed as action items in the record:
imports:and unstagedgh aw logs --outcomeshaven't been measured.partialgate summary hasn't fired yet, because the demo corpus has nopackageorentitymatcher.Notes for review
MANIFEST.md. Nothing under.github/workflows/**changes, so it doesn't needgate-change-acknowledged.adr lintreports 0 errors on 60 records, andcheck:stale-refspasses.