Repository navigation
meshoptimizer-m 1.3.1: built with -ffp-contract=off, the same results on every platform - #1
Merged
Merged
Conversation
…ithout fast math — the same meshlets, clusters and simplifications on every platform. With the platform's default arm64 fuses a multiply and an add into one rounding and a scattered 48 × 48 sheet's meshlets differ from x86-64's (found by a consumer's test on ubuntu-24.04-arm: its widest cluster 1.57 against 1.5); the first wrapper revision (mwrap.md: upstream 1.3, revision 1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The library is built with
-ffp-contract=offand without fast math. With the platform's default, arm64 fuses a multiply and an add into one rounding, so float decisions in the meshlet builder differ from x86-64: a scattered 48 × 48 sheet gives other meshlets (checked standalone on x86-64 with-mfma -ffp-contract=fastagainst-ffp-contract=off: different partitions, widest cluster about 1.78 against 1.38). Found by a consumer's test on ubuntu-24.04-arm. Version 1.3.1 is the first wrapper revision per mcpp-index docs/mwrap.md; the upstream sources are unchanged. Locally: the package's tests pass.