Repository navigation
0.1.1: vm-runner as a stable entry a runner declaration can name - #2
Merged
Merged
Conversation
The image package is named for what it is -- the FreeBSD 14.5-RELEASE boot disk -- with its upstream stated; freebsd-vm said the mechanism, not the thing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The vm-run tool was a development convenience: it booted the image, ran a command, and its exit status was whatever the transport last reported. This promotes it to the entry a machine-side runner declaration names, keeping every existing behaviour and adding the contract such a consumer needs.
--timeout, default 1800) reports and exits 124[target.x86_64-freebsd] runner = ["<this tool>", "{}"]-- the image it expects (the xim freebsd-vm package) and its two qemu dependenciesMeasured on a 14.5 image under KVM: a static x86_64-freebsd probe prints to both streams and returns 42, and 42 is what the tool exits; a second invocation of the same session shape returns its own status; two sessions racing each other return 3 and 5 respectively with no cross-talk; the overlay and temporary directories are removed after each run. The kernel and conformance layers of this repository are untouched.