Repository navigation
0.19.1 --- a name beneath a volume is absolute, and openkal-musl is a compatible range - #67
Merged
Merged
Conversation
…mpatible range libc++ read the C library's volume names (D:/...) as relative POSIX names, so the working directory on Windows was not absolute and absolute, canonical and relative built names that do not exist (#64). The path parser now takes X: followed by / as a root name, as openkal-musl's root_length does, and the append overlay decides absoluteness through path::is_absolute. Both probes state the decomposition, append and working-directory results; without the change four fail on Linux. Co-authored-by: speak-agent <248744407+speak-agent@users.noreply.github.com>
Co-authored-by: speak-agent <248744407+speak-agent@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #64. Part of the openkal 0.24.1 correction group (mcpp design record 2026-11-07 §4.2).
llvm/libcxx/src/filesystem/path_parser.h(in-place marker): underOPENKAL,X:followed by/is a root name in both parse directions;X:alone stays an ordinary name, matching openkal-musl'sroot_length.port/include/__filesystem/path.h(overlay, vendored tree unchanged):append(Source)decides absoluteness throughpath::is_absolute()underOPENKAL/__OPENKAL__, sopath / "D:/y"equalspath / path("D:/y").examples/cxxandexamples/image-cxxstate the decomposition, iteration in both directions,D:/D:xas relative, append,lexically_relative, and the working directory throughabsolute/canonical. Locally on Linux: four observations fail without the change and none with it; the Windows rows exercise the working-directory results.openkal-muslis the compatible range^0.28.0(design §4.2.2, A1);llvm/PATCHES.mdrecords both changes.Co-authored-by: speak-agent