Repository navigation
0.19.2 --- a name rebuilt part by part keeps its volume - #69
Merged
Merged
Conversation
lexically_normal appended the root name D: as an ordinary name, and the root
directory replaced it: D:/a/./b became /a/b, and weakly_canonical and
path("D:/a") / "/b" lost the volume the same way. On Windows a program over
the hosted arrangement named its files beneath no volume, and a launcher could
not start its runner (mcpp-community/mcpp#889, e2e 988). lexically_normal now
begins with the volume and its root directory as written, and appending a
rooted name beneath a volume keeps the volume, as [fs.path.append] states for a
system with root names. Both probes state the three results; without the
change two fail on Linux and under the Windows hosted arrangement (wine).
Co-authored-by: speak-agent <248744407+speak-agent@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #68. The leaf fix of the openkal 0.24.2 patch group (mcpp design 2026-11-07, D12: leaf package + platform patch, one index change).
llvm/libcxx/src/filesystem/path.cpp(in place, marked):lexically_normalbegins its result with the volume and its root directory as written.port/include/__filesystem/path.h:operator/=and bothappendoverloads keep the volume when the appended name has a root directory and no root name.examples/cxx,examples/image-cxx) state the three results.llvm/PATCHES.md, README; version 0.19.2.Verified locally:
examples/cxxon Linux and forx86_64-windows-gnuunder wine pass every probe; without the change thelexically_normalandweakly_canonicalprobes fail.