Repository navigation
0.23.3: the stub of libSystem only when the link has no SDK - #49
Merged
Merged
Conversation
The build program supplied port/ on any requested target. On a Mac with --target aarch64-macos the link carries the SDK (-isysroot, mcpp 2026.8.25.2+), and the stub's three names shadowed the SDK's libSystem (undefined symbol: strlen). It now asks mcpp's MCPP_TARGET_SDK and supplies the stub when a target is requested and no SDK is on the link; an older mcpp sets no such variable and keeps the previous condition. CI runs this package's tests with --target aarch64-macos, which needs mcpp 2026.11.14.1; the pin moves to it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The build program supplied
port/(the three-namelibSystemstub) whenever a target was requested. On a Mac with--target aarch64-macosthe link carries the SDK (-isysroot, mcpp 2026.8.25.2+), and the stub shadowed the SDK's completelibSystem:undefined symbol: strlen,memcpy,pthread_create(mcpp canarycxx aarch64-macos test, every run).build.mcpp: the stub is supplied whenMCPP_TARGET_REQUESTEDis non-empty andMCPP_TARGET_SDKis empty, i.e. a cross link to macOS from another host.MCPP_TARGET_SDKis the SDK the link names, stated by mcpp 2026.11.14.1+ (2026.11.14.1: MCPP_TARGET_SDK; a planned row served by the chosen platform; Windows runner lookup; test discovery skips a package below tests/; release publishes GitHub, index PR, then optional GitCode mcpp-community/mcpp#935). An older mcpp sets no such variable; the condition is then the previous one.--target aarch64-macos. The pin moves to mcpp 2026.11.14.1, which that step needs; until it is released the PR's own run fails at the install, and the change is validated by a dispatched run against the mcpp branch (mcpp_ref).Consumers (
mcpplibs.osdeclares>=0.22.0, <0.24.0) take it without change.