Repository navigation
0.25.3: the suite is an mtest project of its own (tests/cts/mtest.toml) - #68
Merged
Merged
Conversation
…ts program and keeps its run in tests/cts Under 0.25.2 an engine run from tests/cts took the repository's mtest.toml above it: the run was kept in the repository's store, where the implementations' CI does not read it, and a program handed to a runner (node on the Web row) was named relative to the repository's root, so the Web row's suite failed to start. The README's dependency example names the released implementations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Under 0.25.2 an mtest engine run from tests/cts (tools/run-conformance.sh with MTEST set) took the repository's mtest.toml above it. The run was kept in the repository's store, where the implementations' CI does not read it (their report steps found no run), and a program handed to a runner was named relative to the repository's root: on the Web row node was given ./target/... from the wrong directory and the suite exited 1 at start (openkal-emscripten#21).
Verified locally: run-conformance.sh against openkal-emscripten for wasm32-emscripten under node with an mtest engine fails at start before the change and passes after it, with the run kept in tests/cts/.mtest.