Don't force panics in the Rust API#1484
Open
Shnatsel wants to merge 3 commits intomemorysafety:mainfrom
Open
Conversation
This was referenced Apr 4, 2026
kkysen
reviewed
Apr 4, 2026
kkysen
force-pushed
the
dont-force-panics
branch
from
530d6e6 to
be4bee5
Compare
kkysen
approved these changes
Apr 6, 2026
Collaborator
kkysen
left a comment
kkysen
left a comment
There was a problem hiding this comment.
LGTM! Thanks! I also rebased to delete the commit that was reverted instead of keeping the revert commit for it.
Contributor
Author
|
Thanks! I'll resume running the fuzzer once this is merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chroma_location()panic has been actually triggered by #1483, the other two changes are preemptive.