Repository navigation
fix: skip a damaged board dependency and bound user-repo git and preflight output - #309
Merged
Merged
Conversation
…light output
- next_runnable reads depends_on through _parse_deps (a JSON list of
strings only). A damaged row is unsatisfied and skipped with a warning.
Before, 5 of 8 measured damage shapes raised BoardError and blocked every
automatic claim, and {} or "" made the damaged item's dependencies
vacuously done.
- The user-repository git calls in project.py (6) and cli.py (2) run
through worktree._run_git: a wedged git is group-killed after 600s and
reaches each site's existing failure idiom. git_root says the inspection
timed out instead of "not a Git repository".
- The toolgraph preflight runner keeps a 4000-character tail of each
stream; syncmill never reads its stdout and shows a short stderr snippet.
- memory_migration._atomic_json fsyncs the file before the rename and the
directory after it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
On Python 3.14 json.loads accepts the 100000-deep depends_on case, and get() renders it through _load_list, whose repr of the nested list overflows the C stack. The dispatch path under test already handles it; read the state with SQL so the test checks only that path. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small robustness batch from the 2026-11-14 audit roadmap (PR 4). No persisted contract changes.
Board: one damaged
depends_onno longer blocks the boardnext_runnablenow readsdepends_onthrough_parse_deps, which accepts only a JSON list of strings. A damaged row is unsatisfied: it is skipped with a warning, never dispatched, and the items behind it are still claimed.Measured on main with a damaged FIFO head and a healthy tail:
depends_on[oops,null,5,[["a"]], deeply nestedBoardError(no item can be claimed){},"""abc",{"x": 1}a,b,c/xare done[1]An explicit
claim(id)(board run --id) is unchanged.User-repo git calls are bounded
The 6 git calls in
project.pyand 2 incli.py(git_root, marker listing,_git_query, check-ignore ×2,info/exclude, twogit status) now go throughworktree._run_git: a wedged git (hung filter, fsmonitor, credential helper) is group-killed after 600s and reaches each site's existing failure idiom.project.git_rootreports the timeout instead of "not a Git repository".Preflight output is bounded
The three toolgraph
_sync_runcalls passtail_chars=4000. Syncmill never reads the binary's stdout (the verdict is the--outartifact) and shows only a 200-character stderr snippet.tail_charsdrains the rest without a new exception type, so strict-mode outcomes are unchanged.Migration state is durable
memory_migration._atomic_jsonfsyncs the file beforeos.replaceand the directory after it.Tests
tests/test_board.py: 10 damaged shapes; a valid dependency list still dispatches without warning. The old corrupt-depends_onrollback test now injects a different mid-transaction error, so the rollback guarantee is still covered.tests/test_git_timeouts.py(new): AST guard against asubprocess.*git argv inproject.py/cli.py; a wedged fakegitprovesgit_root,_dirty_count,subprocess_status_dirtyandproject_idreturn in bounded time and that git's child dies.tests/test_preflight.py: a real binary floods 4 MiB on each stream; advisory, strict and control paths keep ≤ 4000 characters.tests/test_memory_migration.py: order is write → file fsync → replace → directory fsync.tests/test_project.py: three tests that faked git throughsubprocess.runnow patchproject._run_git.Every new guard was removed one at a time (18 mutations); each removal fails a test. Full hermetic suite clean locally; ruff clean. Codex design review (2 rounds) and implementation review (2 rounds, the second without framing): SHIP, no findings on this scope.
Not in this PR
board showstill renders a damageddepends_onas no dependencies (display only).doctorauth probe (cli.py:661) has a timeout but no process-group kill.🤖 Generated with Claude Code