[MOO-2251] App crash fix occured by folly in debug build#202
Open
saurabhchavan1711 wants to merge 1 commit intomainfrom
Open
[MOO-2251] App crash fix occured by folly in debug build#202saurabhchavan1711 wants to merge 1 commit intomainfrom
saurabhchavan1711 wants to merge 1 commit intomainfrom
Conversation
saurabhchavan1711
changed the title
saurabhchavan1711
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Debug builds crash with SIGABRT in F14SetFallback.h:234 on Xcode 26 when the New Architecture passes data through F14 hash maps.
Root Cause
Folly uses reinterpret_cast to access std::unordered_set private internals — an unsafe hack. Xcode 26's libc++ changed the internal layout, causing a debug-only assertion (FOLLY_SAFE_DCHECK) to fail. Release builds are unaffected as they already define NDEBUG.
Fix
Define NDEBUG=1 for all pod targets in Debug configuration, matching Release behavior. Must apply to all targets because F14SetFallback.h is a header-only template compiled by any including target.