You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
set P_LORA_RESET to 12 for the Heltec Wireless Tracker variant
align the SX1262 reset wiring with Heltec's published tracker pin map
leave the rest of the tracker board definition unchanged
Why this is the right fix
Heltec's Wireless Tracker documentation shows the SX1262 reset line on GPIO12 as LoRa_RST. MeshCore already passes P_LORA_RESET into the Heltec Tracker radio Module constructor, so leaving this variant at RADIOLIB_NC treated a documented hardware reset line as disconnected.
Setting P_LORA_RESET to 12 brings the tracker variant in line with the published board wiring instead of introducing any new board behavior.
Looking through the history, this fix also seems justified.
The mismatch entered the tree in 5b7d7386 ("fix building issues with heltec wireless paper and heltec tracker"), which set P_LORA_RESET=RADIOLIB_NC in variants/heltec_tracker/platformio.ini. I reviewed the later history and did not find any explanation for why the tracker variant should leave SX1262 reset disconnected even though the target code passes P_LORA_RESET straight into the radio Module constructor.
So this looks like the same class of board-definition bug as the Heltec V3 issue rather than a deliberate behavior choice. Heltec's tracker documentation shows LoRa_RST on GPIO12, so changing the variant to use 12 is consistent with the vendor pin map and the way the radio is already instantiated in the code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why this is the right fix
Heltec's Wireless Tracker documentation shows the SX1262 reset line on GPIO12 as LoRa_RST. MeshCore already passes P_LORA_RESET into the Heltec Tracker radio Module constructor, so leaving this variant at RADIOLIB_NC treated a documented hardware reset line as disconnected.
Setting P_LORA_RESET to 12 brings the tracker variant in line with the published board wiring instead of introducing any new board behavior.
Authoritative source:
Validation