Fix Heltec Wireless Paper LoRa reset pin#2059
Open
robekl wants to merge 1 commit intomeshcore-dev:devfrom
Open
Fix Heltec Wireless Paper LoRa reset pin#2059robekl wants to merge 1 commit intomeshcore-dev:devfrom
robekl wants to merge 1 commit intomeshcore-dev:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why this is the right fix
Heltec's Wireless Paper schematic shows the LoRa control lines on the same GPIO8-14 pattern used by the other SX1262-based Heltec ESP32-S3 boards, including the reset line on GPIO12. MeshCore already passes P_LORA_RESET into the Wireless Paper radio Module constructor, so leaving this variant at RADIOLIB_NC treated that documented reset line as disconnected.
Setting P_LORA_RESET to 12 brings the board definition in line with the published hardware wiring without changing any other board-specific behavior.
Authoritative source:
Validation