Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
P0.9toP1.9P1.13flash-enable pad in the pin map commentsIssue
The current T1000-E variant has a few stale or incomplete pin comments that do not match the current official board table:
P_LORA_MOSI=41is commented asP0.9, but digital pin 41 isP1.09P1.13unlabeled even though the current T1000-E documentation identifies it as the flash-enable signalThese are comment-level issues, but they make future board review and maintenance harder and increase the chance of accidental pin regressions.
Authoritative source
Seeed Studio's current official T1000-E page:
Relevant entries:
P1.09is the LR1110 MOSI lineP1.13is flash enableFix
This PR updates only comments in:
variants/t1000-e/platformio.inivariants/t1000-e/variant.hvariants/t1000-e/variant.cppNo runtime logic, macros, or board behavior changed.
Why this helps
MeshCore carries a large number of board variants, so accurate inline pin documentation matters. This keeps the T1000-E metadata aligned with the vendor documentation and reduces the chance of future wiring mistakes during review or follow-up feature work.
Validation
pio run -e t1000e_companion_radio_ble