Repository navigation
Comments: the object stride with instance colours - #86
Merged
Merged
Conversation
scene.rs named `tinted_source`, removed by #80. The particle shaders said their objects never have instance colours; gpu.rs writes a stride of 4 into them for such scenes. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two comments left wrong after #80, found in a review of it. No code change.
scene.rs: namedtinted_source, which A scene's features as FEAT bits: vertex colours, grids, instance colours, unlit, background #80 removed.particles.wgsl,gpu_particles.wgsl: said particles' objects never have instance colours;gpu.rswrites a stride of 4 into them for such scenes.🤖 Generated with Claude Code
Note
Low Risk
Comment-only changes with no runtime or shader logic modified.
Overview
Fixes comment-only drift after #80 around instance-coloured scenes and object-table stride.
In
particles.wgslandgpu_particles.wgsl, theOBJECT_STRIDEnote now matches reality: the shaders still use3u, but when a scene has instance colours,gpu.rslays out four vec4s per object (seescene.rsobject_stride), so the old “particles never have instance colours” wording was wrong.In
scene.rs, the build comment no longer cites the removedtinted_sourcehook ingpu.rs; it only ties F_TINT to four vec4 object entries.Reviewed by Cursor Bugbot for commit 21c6193. Bugbot is set up for automated code reviews on this repo. Configure here.