Repository navigation
Conversation
Summary: # Why Subtracting a nonzero start time from a simulated completion timestamp can round the elapsed duration down. The benchmark metric then excludes the final observation even though the simulator has completed the trial. # Changes - Compare observation timestamps with the simulator clock or recorded completion timestamp on the same absolute-time basis. - Preserve running and early-stopped cutoffs and the existing rejection of future completion timestamps, without adding a numerical tolerance. - Cover the cancellation case, the representable instant immediately before completion, early stopping, and later fetches for map and time-varying metrics. # Examples For start time `192.0` and runtime `320.10965660870767`, subtracting the start from the completion timestamp yields `320.1096566087076`. Previously the final row was excluded; it is now retained at completion. Stopping at the preceding representable timestamp still excludes it. Differential Revision: D130806064
meta-cla
Bot
added
the
CLA Signed
|
@ltiao has exported this pull request. If you are a Meta employee, you can view the originating Diff in D130806064. |
|
This pull request has been merged in 45a6584. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Why
Subtracting a nonzero start time from a simulated completion timestamp can round the elapsed duration down. The benchmark metric then excludes the final observation even though the simulator has completed the trial.
Changes
Examples
For start time
192.0and runtime320.10965660870767, subtracting the start from the completion timestamp yields320.1096566087076. Previously the final row was excluded; it is now retained at completion. Stopping at the preceding representable timestamp still excludes it.Differential Revision: D130806064