Repository navigation
fix(core): docusaurus serve answers 400 to null bytes - #12913
Merged
Merged
Conversation
serve-handler answered 500, because its file system calls throw. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 1 minute. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
✅ [V2]
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Size Change: 0 B Total Size: 12.1 MB ℹ️ View Unchanged
|
⚡️ Lighthouse report for the deploy preview of this PR
|
|
Size Change: 0 B Total Size: 12.1 MB ℹ️ View Unchanged
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
docusaurus serveanswered 500 to null bytes like/%00, because the serve-handler file system calls throw. It now answers 400, like serve-handler does to malformed percent-encodings. Like serve-handler, only the pathname is checked: a null byte in the query string is still served.Test Plan
Flips the TODO test of #12910, and updates the
/%00lines of the snapshots, from500to400(trailingSlash: truealso skips the redirect to/%00/). Adds a test for a null byte in the query string.Test links
Deploy preview: https://deploy-preview-12913--docusaurus-2.netlify.app/
Related issues/PRs
Stacked on #12912.
🤖 Generated with Claude Code