Skip to content

test(core): capture how docusaurus serve handles client redirect files of .html paths #12919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
slorber merged 2 commits into from
Nov 6, 2026
Merged

test(core): capture how docusaurus serve handles client redirect files of .html paths #12919

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c20216c
test(core): capture how `docusaurus serve` handles client redirect fi…
slorber Nov 6, 2026
05fa68c
test(core): name the client redirect fixtures after their shape, requ…
slorber Nov 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/docusaurus/src/commands/serve/__tests__/__fixtures__/build/legacy.html/index.html
View file
Open in desktop

This file was deleted.

1 change: 1 addition & 0 deletions packages/docusaurus/src/commands/serve/__tests__/__fixtures__/build/redirect-file.html.html
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions ...ocusaurus/src/commands/serve/__tests__/__fixtures__/build/redirect-folder.html/index.html
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

61 changes: 53 additions & 8 deletions packages/docusaurus/src/commands/serve/__tests__/requestHandler.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,12 @@ const RequestPaths = [
'/missing',
'/missing/',
'/missing.html',
// A client redirect file, from /legacy.html
'/legacy.html',
// Client redirect files, for redirects from a .html path
// plugin-client-redirects writes a folder, or a file with trailingSlash false
'/redirect-folder.html',
'/redirect-folder.html/',
'/redirect-file.html',
'/redirect-file.html/',

'/file?query=1',
'/file/?query=1',
Expand Down Expand Up @@ -151,7 +155,10 @@ describe('createServeRequestHandler', () => {
/missing 404 404.html
/missing/ 404 404.html
/missing.html 301 /missing → 404 404.html
/legacy.html 301 /legacy → 404 404.html
/redirect-folder.html 301 /redirect-folder → 404 404.html
/redirect-folder.html/ 200 redirect-folder.html/index.html
/redirect-file.html 301 /redirect-file → 404 404.html
/redirect-file.html/ 200 redirect-file.html.html
/file?query=1 200 file.html
/file/?query=1 200 file.html
/file.html?query=1 200 file.html
Expand Down Expand Up @@ -212,7 +219,10 @@ describe('createServeRequestHandler', () => {
/missing 301 /missing/ → 404 404.html
/missing/ 404 404.html
/missing.html 301 /missing → 301 /missing/ → 404 404.html
/legacy.html 301 /legacy → 301 /legacy/ → 404 404.html
/redirect-folder.html 301 /redirect-folder → 301 /redirect-folder/ → 404 404.html
/redirect-folder.html/ 200 redirect-folder.html/index.html
/redirect-file.html 301 /redirect-file → 301 /redirect-file/ → 404 404.html
/redirect-file.html/ 200 redirect-file.html.html
/file?query=1 301 /file/?query=1 → 200 file.html
/file/?query=1 200 file.html
/file.html?query=1 200 file.html
Expand Down Expand Up @@ -273,7 +283,10 @@ describe('createServeRequestHandler', () => {
/missing 404 404.html
/missing/ 301 /missing → 404 404.html
/missing.html 301 /missing → 404 404.html
/legacy.html 301 /legacy → 404 404.html
/redirect-folder.html 301 /redirect-folder → 404 404.html
/redirect-folder.html/ 301 /redirect-folder.html → 301 /redirect-folder → 404 404.html
/redirect-file.html 301 /redirect-file → 404 404.html
/redirect-file.html/ 301 /redirect-file.html → 301 /redirect-file → 404 404.html
/file?query=1 200 file.html
/file/?query=1 301 /file?query=1 → 200 file.html
/file.html?query=1 200 file.html
Expand Down Expand Up @@ -336,7 +349,10 @@ describe('createServeRequestHandler', () => {
/base/missing 404 404.html
/base/missing/ 404 404.html
/base/missing.html 301 /base/missing → 404 404.html
/base/legacy.html 301 /base/legacy → 404 404.html
/base/redirect-folder.html 301 /base/redirect-folder → 404 404.html
/base/redirect-folder.html/ 200 redirect-folder.html/index.html
/base/redirect-file.html 301 /base/redirect-file → 404 404.html
/base/redirect-file.html/ 200 redirect-file.html.html
/base/file?query=1 200 file.html
/base/file/?query=1 200 file.html
/base/file.html?query=1 200 file.html
Expand Down Expand Up @@ -397,7 +413,10 @@ describe('createServeRequestHandler', () => {
/base/missing 301 /base/missing/ → 404 404.html
/base/missing/ 404 404.html
/base/missing.html 301 /base/missing → 301 /base/missing/ → 404 404.html
/base/legacy.html 301 /base/legacy → 301 /base/legacy/ → 404 404.html
/base/redirect-folder.html 301 /base/redirect-folder → 301 /base/redirect-folder/ → 404 404.html
/base/redirect-folder.html/ 200 redirect-folder.html/index.html
/base/redirect-file.html 301 /base/redirect-file → 301 /base/redirect-file/ → 404 404.html
/base/redirect-file.html/ 200 redirect-file.html.html
/base/file?query=1 301 /base/file/?query=1 → 200 file.html
/base/file/?query=1 200 file.html
/base/file.html?query=1 200 file.html
Expand Down Expand Up @@ -458,7 +477,10 @@ describe('createServeRequestHandler', () => {
/base/missing 404 404.html
/base/missing/ 301 /base/missing → 404 404.html
/base/missing.html 301 /base/missing → 404 404.html
/base/legacy.html 301 /base/legacy → 404 404.html
/base/redirect-folder.html 301 /base/redirect-folder → 404 404.html
/base/redirect-folder.html/ 301 /base/redirect-folder.html → 301 /base/redirect-folder → 404 404.html
/base/redirect-file.html 301 /base/redirect-file → 404 404.html
/base/redirect-file.html/ 301 /base/redirect-file.html → 301 /base/redirect-file → 404 404.html
/base/file?query=1 200 file.html
/base/file/?query=1 301 /base/file?query=1 → 200 file.html
/base/file.html?query=1 200 file.html
Expand Down Expand Up @@ -815,6 +837,29 @@ describe('createServeRequestHandler', () => {
);
});

// TODO fix: "200 redirect-folder.html/index.html"
// plugin-client-redirects writes it for redirects from /redirect-folder.html
it('serves no client redirect folder of .html paths', async () => {
await expect(
serveRequest(
{baseUrl: '/base/', trailingSlash: undefined},
'/base/redirect-folder.html',
),
).resolves.toBe('301 /base/redirect-folder → 404 404.html');
});

// TODO fix: "200 redirect-file.html.html"
// plugin-client-redirects writes it for redirects from /redirect-file.html,
// with trailingSlash false
it('serves no client redirect file of .html paths', async () => {
await expect(
serveRequest(
{baseUrl: '/base/', trailingSlash: false},
'/base/redirect-file.html',
),
).resolves.toBe('301 /base/redirect-file → 404 404.html');
});

// Like the malformed percent-encodings
it('answers 400 to null bytes', async () => {
await expect(
Expand Down
Loading