Repository navigation
Conversation
…ml paths Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. Walkthrough
Merge Risk:
 |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
✅ [V2]
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Size Change: 0 B Total Size: 12.1 MB ℹ️ View Unchanged
|
⚡️ Lighthouse report for the deploy preview of this PR
|
|
Size Change: 0 B Total Size: 12.1 MB ℹ️ View Unchanged
|
…erve-html-client-redirects # Conflicts: # packages/docusaurus/src/commands/serve/__tests__/requestHandler.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
For a redirect from a
.htmlpath, likefrom: '/old-page.html',@docusaurus/plugin-client-redirectswritesold-page.html/index.html, orold-page.html.htmlwithtrailingSlash: false.docusaurus serveredirected/old-page.htmlto/old-page, which is a 404, so these redirects never worked. The previous PR of this stack captures the bug.docusaurus servenow treats a.htmlpath as a page when one of these 2 files exists:trailingSlashredirect like for other pages:/old-page.htmlredirects to/old-page.html/withtrailingSlash: true.cleanUrlsoption would redirect the.htmlpath, and without it, serve-handler doesn't look for these files.End-to-end check: a real site built with plugin-client-redirects
/old-page.htmlrequested on the build output, before and after:Test Plan
pnpm test packages/docusaurus/src/commands/serve. Only the/redirect-folder.html(/)and/redirect-file.html(/)snapshot rows change, and the 2TODO fixtests are flipped.Test links
Deploy preview: https://deploy-preview-12920--docusaurus-2.netlify.app/
Related issues/PRs
Stacked on meta/docusaurus#12919
🤖 Generated with Claude Code
Summary by CodeRabbit
.htmlURLs. These pages now resolve to their corresponding content across trailing-slash settings and base URLs.