Repository navigation
fix Completion returns no items inside a function body when the typed text is a keyword (as, in, is, ...) #5529 - #5617
Open
asukaminato0721 wants to merge 2 commits into
Open
asukaminato0721 wants to merge 2 commits into
asukaminato0721 wants to merge 2 commits into
Conversation
Contributor
|
This pull request has been imported. If you are a Meta employee, you can view this in D131272332. (Because this pull request was imported automatically, there will not be any future comments.) |
This comment has been minimized.
This comment has been minimized.
stroxler
requested changes
Nov 11, 2026
stroxler
left a comment
Contributor
There was a problem hiding this comment.
From an initial AI-assisted review, I think the overall structure here is good but we want a couple of fixes before we merge:
- P2 — Preserve the typed-prefix completion-list contract. The new fallback supplies a nonempty list marked complete even though later typing enables deferred auto-import candidates absent from that list. Recover/reuse the normal prefix behavior, including
isIncompletewhen more typing requires a new request. - P2 — Cover nested inline-suite statement starts. The boundary condition accepts a newline or semicolon but misses a nested inline suite following a compound-statement colon. This is incomplete intended scope, not a newly introduced regression. Do not simply accept every colon: dictionaries, slices, and annotations also contain colons.
asukaminato0721
force-pushed
the
5529
branch
from
November 12, 2026 03:44
38f6922 to
90c98b3
Compare
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5529
Completion now returns suggestions after as, in, and is at statement starts.
Test Plan
add test