Repository navigation
Conversation
Contributor
|
This pull request has been imported. If you are a Meta employee, you can view this in D131294105. (Because this pull request was imported automatically, there will not be any future comments.) |
stroxler
approved these changes
Nov 11, 2026
stroxler
left a comment
stroxler
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
Contributor
|
This pull request has been merged in 175a253. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Previously,
Array.reshape(*shape: *NewShape)andjax.numpy.reshape(x, shape: NewShape)returnedArray[NewShape]directly without evaluatingreshape_shape. As a result, calls likea.reshape(n, -1)orjnp.reshape(a, (n, -1))captured-1as a literalInt[-1]dimension in the output shape, causing downstream shape and broadcasting errors.This change generalizes the
reshape_shapeDSL functions to handle placeholder-1dimensions uniformly across concrete, symbolic (Int[N]), and gradual shapes.