Skip to content

[tensor-shapes] add missing primitive declarations in jax.lax - #5620

Closed
jakevdp wants to merge 1 commit into
meta:mainfrom
jakevdp:missing-signatures
Closed

jakevdp wants to merge 1 commit into
meta:mainfrom
jakevdp:missing-signatures

Conversation

@jakevdp

@jakevdp jakevdp commented Nov 11, 2026

Copy link
Copy Markdown
Contributor

Summary

Add jax.lax.abs_p and other primitive definitions. These are exporded in jax.lax, but are missing in the pyrefly shape stubs.

  • I am a human, and I fully understand the code I am submitting.

@meta-cla meta-cla Bot added the cla signed label Nov 11, 2026
@github-actions github-actions Bot added google issues from google size/l labels Nov 11, 2026
@github-actions

Copy link
Copy Markdown

✅ This PR meets all requirements from our pull request checklist.

Optional recommendations:

  • If this PR addresses an open issue, please link the issue in the PR description and claim it.
  • This PR is on the larger side. If parts of it could be merged on their own, consider splitting it into separate PRs for faster review. If you've already split it as far as is practical, no action is needed.

Note: this comment updates automatically after changes to the PR. Updates may take up to half an hour.

@meta-codesync

meta-codesync Bot commented Nov 11, 2026

Copy link
Copy Markdown
Contributor

This pull request has been imported. If you are a Meta employee, you can view this in D131306786. (Because this pull request was imported automatically, there will not be any future comments.)

@stroxler stroxler self-assigned this Nov 11, 2026

@stroxler stroxler left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review automatically exported from Phabricator review in Meta.

@meta-codesync

meta-codesync Bot commented Nov 11, 2026

Copy link
Copy Markdown
Contributor

This pull request has been merged in 179c178.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants