Repository navigation
Give both stores the same cache budget - #40
Merged
Merged
Conversation
--cache-mb sets JE's cache to exactly that many bytes and sizes HStore's node cache as the budget divided by the page size. Without it both keep their current defaults.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #32
Adds
--cache-mb(CACHE_MBinrun.sh):setCacheSizeon the JE environment, exactly that many bytesbudget / pageSizenodesWithout the option both keep their current defaults, so existing results stay comparable. Runs with a budget go to a
-cache-<mb>results directory, and the report's Caches line says what each store was given.Two things can't be matched exactly, and the docs say so:
The retained-heap line from #39 shows what each store really kept.
Smoke run at scale 1, async,
CACHE_MB=64, so the data (95 to 250 MiB on disk) doesn't fit:read.members(113k down to 57k ops/s). Incidence reads barely change.The docs also note that the OS page cache will usually still serve these "misses" from memory, unless the data is bigger than the machine's free RAM.