Skip to content

Bump action github#96

Open
VincentLanglet wants to merge 1 commit into
mheap:mainfrom
VincentLanglet:bumpAction
Open

Bump action github#96
VincentLanglet wants to merge 1 commit into
mheap:mainfrom
VincentLanglet:bumpAction

Conversation

@VincentLanglet
Copy link
Copy Markdown

First bump, from v5 to v7, stop using nock and just jest instead.

@mheap
Copy link
Copy Markdown
Owner

mheap commented Apr 29, 2026

Thanks @VincentLanglet. This works, but it removes the confidence I have when upgrading @actions/github as the HTTP client is now mocked and the signature may have changed.

I think the msw path is better as we can assert actual HTTP requests

@VincentLanglet
Copy link
Copy Markdown
Author

Thanks @VincentLanglet. This works, but it removes the confidence I have when upgrading @actions/github as the HTTP client is now mocked and the signature may have changed.

I think the msw path is better as we can assert actual HTTP requests

I didn't succeed with msw but it worked with undici @mheap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants