Skip to content

ga-IE translation#111

Merged
microbit-matt-hillsdon merged 2 commits into
mainfrom
ga-ie
Jun 10, 2025
Merged

ga-IE translation#111
microbit-matt-hillsdon merged 2 commits into
mainfrom
ga-ie

Conversation

@microbit-matt-hillsdon
Copy link
Copy Markdown
Contributor

No description provided.

This one is very quick anyway.
uses: actions/setup-node@v2
with:
node-version: ${{ matrix.node-version }}
cache: 'npm'
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prettier is a shame but not worth fighting. Actual change is to drop the cache: "npm" line due to cryptic failures in GH actions. There's no cache I can delete via the UI and the dependencies are quick to install.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to drop the caching, but I wonder if reinstating the caching after running the action without it might fix it?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried that and it didn't work 😢

I then dropped those commits from the history of this PR.

@microbit-matt-hillsdon microbit-matt-hillsdon requested a review from a team June 10, 2025 09:06
Copy link
Copy Markdown
Contributor

@microbit-robert microbit-robert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@microbit-matt-hillsdon microbit-matt-hillsdon merged commit fee713c into main Jun 10, 2025
1 check passed
@microbit-matt-hillsdon microbit-matt-hillsdon deleted the ga-ie branch June 10, 2025 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants