Skip to content

Handle expected plain-text errors in the Airlock E2E request helper #5174

Closed

Description

@JayDoubleu

The Airlock helper attempted JSON decoding after expected HTTP 400 and 404 responses with plain-text bodies. Correct access-denial responses therefore failed the tests.

Related changes are combined into fewer PRs for review. Earlier PRs and test results remain as historical evidence.

Current position

Item Status and evidence
Current implementation PR #5255
Earlier PRs PR #5193
Completion Merging PR #5255 into main closes this issue.
Position Response handling corrected; both selected Airlock runs passed.
Observed failure Airlock error-response failures.
Live validation 12 API/storage cases passed. Tests c486c015, deployment f957b6bc; request, approval, rejection, cancellation, storage and isolation checks passed with cleanup.
Live validation 2 targeted cases passed. Tests and deployment c486c015; draft deletion and import review VM flow passed. API and Azure cleanup were verified.

Scope

  • Keep exact status assertions and decode expected error responses as plain text.
  • Preserve JSON decoding for successful responses and keep SAS-bearing response bodies out of logs.

Remaining work

  • Merge the reviewed response-helper correction.

The timeout from the same run is tracked in #5175.

Related work

Parent: #5119.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions