Skip to content

Wait for draft-container deletion before asserting Airlock SAS revocation #5181

Closed

Description

@JayDoubleu

The draft-container test assumed deletion was immediate and treated one SAS error as proof of container state. Later validation returned AuthorizationPermissionMismatch after the draft had been deleted.

Related changes are combined into fewer PRs for review. Earlier PRs and test results remain as historical evidence.

Current position

Item Status and evidence
Current implementation PR #5255, merged into main at 0c5027e.
Earlier PRs PR #5194, PR #5241, PR #5258
Completion The deletion checks are merged and validated. Submitted-file integrity coverage is tracked separately in #5264, under #5124.
Position Bounded waiting and independent draft-deletion checks passed. The completed scope is draft removal, rejected writes and submitted-container metadata.
Observed failures Original timing failure; SAS error mismatch.
Earlier Azure validation 2 targeted cases passed. Tests and deployment c486c015; draft deletion and import review VM flow passed. API and Azure cleanup were verified.
Latest Azure validation 2 targeted Airlock cases passed, attempt 1, at combined test revision 1cec703. These cases cover draft deletion and the import review VM flow.
Evidence limits The draft-deletion case requires a rejected write, ARM confirmation that the draft container is absent, and matching submitted-container metadata. It does not read or compare submitted file contents.

Scope

  • Wait for the old SAS to stop accepting writes and independently require Azure Resource Manager to report the draft container absent.
  • Verify that the submitted container remains with the expected workspace and import-stage metadata.
  • Fail on a surviving draft, unrelated storage errors or an inconclusive Azure check.

Completed scope

The file-content checks in #5264 remain unfinished. Closing this issue records completion of the validated draft-deletion scope.

Related work

Parent: #5119.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions