You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Recover Airlock review-VM cleanup after a failed CustomScript extension #5183
The Airlock test failed to delete a review VM after its CustomScript extension failed. Cleanup did not correctly handle the resulting deployment and disable states.
Related changes are combined into fewer PRs for review. Earlier PRs and test results remain as historical evidence.
2 targeted cases passed. At c486c015, review-VM approval and automatic deletion passed. API and Azure checks confirmed the VM and workspace were removed.
Failure prevention
PR #5253 verifies Azure CLI installation. PR #5255 provides Nexus test prerequisites and cleanup recovery.
Scope
Wait for provisioning to reach a terminal state before cleanup.
Confirm that the resource is disabled, then permit deletion even if the disable operation failed.
Track accepted resources, clean up children first and retain the original test failure.
Remaining work
Merge the reviewed recovery and prerequisite corrections in PR #5255.
The targeted run above verifies normal automatic deletion. It does not reproduce the earlier extension failure, whose API recovery is separate evidence.
#5184 now includes the missing certificate/Nexus descriptions, API-schema regression coverage, and #5187's Azure CLI compatibility fix.
Targeted retest is deploying 226013fb20df046714f3d7346b33d39fa5463c8c. The workflow starts the environment before testing because the preceding reuse attempt found an unallocated firewall and timed out connecting to the API.
A subsequent test-harness fix at c9df39b0 prevents restored cleanup timers from interrupting teardown error reporting. All 68 local helper tests and applicable hooks passed. Unrelated finalisers retain timeout coverage.
The targeted review flow and full Airlock suite remain pending. The full-suite follow-up will use the latest branch revision.
Activity
Use registered branch workflow for scoped recovery #5183
Pin the private API public certificate for scoped recovery #5183
Bound asynchronous workspace setup waits for #5183
Allow read-only operation status during recovery #5183
Clean up resources accepted before setup cancellation (#5183)
Add targeted Airlock validation selector (#5181, #5182, #5183)
Recover accepted review VMs before workspace teardown (#5183)
Preserve unrelated fixture teardown deadlines (#5183)
Keep timeout regression reporting within its watchdog (#5183)
Stop restored cleanup timers before pytest reporting (#5183)
JayDoubleu commentedon Oct 10, 2026
#5184 now includes the missing certificate/Nexus descriptions, API-schema regression coverage, and #5187's Azure CLI compatibility fix.
Targeted retest is deploying
226013fb20df046714f3d7346b33d39fa5463c8c. The workflow starts the environment before testing because the preceding reuse attempt found an unallocated firewall and timed out connecting to the API.A subsequent test-harness fix at
c9df39b0prevents restored cleanup timers from interrupting teardown error reporting. All 68 local helper tests and applicable hooks passed. Unrelated finalisers retain timeout coverage.The targeted review flow and full Airlock suite remain pending. The full-suite follow-up will use the latest branch revision.
Bound nested cleanup and retain review VM ownership (#5183)
Carry prerequisite evidence and bounded Airlock cleanup (#5125, #5183)
Model approval failures explicitly in cleanup tests (#5183)
Model approval failures explicitly in cleanup tests (#5183)