Skip to content

Recover Airlock review-VM cleanup after a failed CustomScript extension #5183

Closed

Description

@JayDoubleu

The Airlock test failed to delete a review VM after its CustomScript extension failed. Cleanup did not correctly handle the resulting deployment and disable states.

Related changes are combined into fewer PRs for review. Earlier PRs and test results remain as historical evidence.

Current position

Item Status and evidence
Current implementation PR #5255
Earlier PRs PR #5192, PR #5194
Completion Closes when the reviewed cleanup recovery and prerequisite corrections in PR #5255 merge.
Position Cleanup recovery implemented and verified through API recovery and later successful validation.
Observed failure Failed review-VM cleanup.
Live validation 2 targeted cases passed. At c486c015, review-VM approval and automatic deletion passed. API and Azure checks confirmed the VM and workspace were removed.
Failure prevention PR #5253 verifies Azure CLI installation. PR #5255 provides Nexus test prerequisites and cleanup recovery.

Scope

  • Wait for provisioning to reach a terminal state before cleanup.
  • Confirm that the resource is disabled, then permit deletion even if the disable operation failed.
  • Track accepted resources, clean up children first and retain the original test failure.

Remaining work

  • Merge the reviewed recovery and prerequisite corrections in PR #5255.

The targeted run above verifies normal automatic deletion. It does not reproduce the earlier extension failure, whose API recovery is separate evidence.

The related setup failure is tracked in #5182.

Related work

Parent: #5119.

Activity

  1. JayDoubleu commented on Oct 10, 2026

    @JayDoubleu
    CollaboratorAuthor

    #5184 now includes the missing certificate/Nexus descriptions, API-schema regression coverage, and #5187's Azure CLI compatibility fix.

    Targeted retest is deploying 226013fb20df046714f3d7346b33d39fa5463c8c. The workflow starts the environment before testing because the preceding reuse attempt found an unallocated firewall and timed out connecting to the API.

    A subsequent test-harness fix at c9df39b0 prevents restored cleanup timers from interrupting teardown error reporting. All 68 local helper tests and applicable hooks passed. Unrelated finalisers retain timeout coverage.

    The targeted review flow and full Airlock suite remain pending. The full-suite follow-up will use the latest branch revision.

  2. added
    v0.30.0-prep-v2Current v0.30.0 preparation: stacked PRs and open follow-up issues. Keep after closure.
    bugSomething isn't working
    and removed
    v0.30.0-prep-v2Current v0.30.0 preparation: stacked PRs and open follow-up issues. Keep after closure.
    on Oct 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions