Skip to content

Forward explicit Nexus consent through the Airlock slash command #5201

Closed

Description

@JayDoubleu

The Airlock slash command could not forward explicit Nexus EULA acceptance. A clean review-VM run could not create its Nexus prerequisite through that command.

Related changes are combined into fewer PRs for review. Earlier PRs and test results remain as historical evidence.

Current position

Item Status and evidence
Current implementation PR #5255
Earlier PRs PR #5203
Completion Merged through PR #5255. The post-merge checks below are complete.
Position Explicit Nexus consent passed through the Airlock PR-comment route. All 14 selected cases and their cleanup completed successfully.
Earlier CI 225 workflow-script tests, repository checks and strict documentation build passed for PR #5203.
Earlier Azure validation 2 targeted cases passed. The branch workflow passed at c486c015 with explicit Nexus consent. This does not exercise the parser on main.

Post-merge validation

The Airlock run passed 23 smoke and all 14 Airlock cases, with no skips. Logs confirm TEST_ACCEPT_NEXUS_EULA=true, the expected checkout, import review-VM execution and test-resource/workspace deletion.

Validation used PR #5265, reviewed head f2bf3ba9ecfdf718156e89dc1a15a5bd96b91779 and test checkout f36d3db031217ad11f2937f8fe2bcf6c7bd807a0. The draft differs from merged main at 0c5027e only by a validation note. Implementation, workflow and test code are unchanged. API deletion is not a complete Azure resource inventory.

Scope

  • Accept an optional SHA and the exact accept_nexus_eula flag on the command's first line.
  • Keep consent false when absent. Reject duplicate flags, unsupported arguments and unauthorised execution.

Completion

  • Merge the reviewed parser and workflow changes in PR #5255.

Earlier command results remain in #5136. The completed route check is also recorded in #5119. Related documentation: #5131.

Related work

Parent: #5119.

Metadata

Metadata

Assignees

No one assigned

    Labels

    airlockbugSomething isn't workingworkflowsGitHub workflows (CI/CD)

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions