Skip to content

Scheduled cleanup ignores recent branch validation activity #5231

Closed

Description

@JayDoubleu

Scheduled cleanup stopped a recently used validation environment because it measured inactivity from the branch commit alone. The deployment lock prevented overlap, but recent completed validation did not extend the inactivity window.

Related changes are combined into fewer PRs for review. Earlier PRs and test results remain as historical evidence.

Current position

Item Status and evidence
Current implementation PR #5255, merged into main at 0c5027e.
Earlier PRs PR #5232
Completion Fixed in merged PR #5255. Closure is supported by automated checks, the activity-history check and recorded live cleanup evidence.
Position The workflow corrections are merged and scheduled cleanup is enabled. Cleanup of deleted-branch and merged-PR environments passed. Additional live scenarios remain unperformed, as recorded below.
Observed sequence Shared-service validation followed by scheduled cleanup.
CI 249 Python and 178 JavaScript tests passed. A read-only history check recognised recent branch activity.
Disposable cleanup validation Cleanup validation job, attempt 1, passed 14 live checks at ff7f4c3. Test groups were removed. Other group names and tags were unchanged.
Workflow status Clean Validation Environments was active when checked on 16 October 2026.
Scheduled cleanup Run 38946162180, attempt 1, passed at integrated revision 0c5027e990d6832e21bafc1dc004594e9e945d1d. It removed the core and management resource groups for the deleted validation branch and merged PRs #5252, #5253, #5254 and #5255.
Azure removal verification A read-only Azure check on 16 October 2026 confirmed that all ten resource groups named in those five job logs were absent.
Evidence limits The disposable validation run skipped normal cleanup jobs. The later scheduled run proves removal for the recorded deleted-branch and merged-PR cases. It does not establish queued deployment/cleanup coordination or the inactivity decision after recent validation on a retained reference.

Scope

  • Use the later of commit time and matching branch-run activity.
  • Take the deployment lock before preparation and recheck queued work before cleanup.
  • Defer cleanup when activity history is incomplete or pending work is ambiguous.

Completion

  • Merge both workflow-path changes through Protect CI environments and add targeted E2E validation #5255.
  • Re-enable Clean Validation Environments after validation.
  • Record the disposable cleanup checks and their limits.
  • Verify scheduled cleanup of deleted-branch and merged-PR environments, including Azure resource-group removal.

Additional live checks not performed

  • Controlled queued deployment/cleanup coordination with a fresh dispatch.
  • Recent validation postponing cleanup of a retained reference, followed by cleanup after the inactivity threshold.

These additional confidence checks are not required for this closure. They were not performed and are not claimed as passing.

Related work

Parent: #5119.

Activity

  1. added
    v0.30.0-prep-v2Current v0.30.0 preparation: stacked PRs and open follow-up issues. Keep after closure.
    on Oct 11, 2026
  2. added a commit that references this issue on Oct 11, 2026
    3b5ca6b
  3. added
    bugSomething isn't working
    workflowsGitHub workflows (CI/CD)
    and removed
    v0.30.0-prep-v2Current v0.30.0 preparation: stacked PRs and open follow-up issues. Keep after closure.
    on Oct 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingdeploymentworkflowsGitHub workflows (CI/CD)

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions