Repository navigation
Implements address space cleanup when a workspace service is uninstalled #4744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
James Chapman (JC-wk)
wants to merge
112
commits into
microsoft:main
from
JC-wk:deallocate-ip-addresses
Closed
Changes from all commits
Commits
Show all changes
112 commits
Select commit
Hold shift + click to select a range
c83471e
Implement address space removal
JC-wk 029f506
update template versions
JC-wk 1abd135
Merge branch 'main' into deallocate-ip-addresses
JC-wk c9f9307
Move address_space deletion to service_bus
JC-wk f38ef4a
Merge branch 'main' into deallocate-ip-addresses
JC-wk 8f722aa
Merge branch 'main' into deallocate-ip-addresses
539c4ab
Merge branch 'main' into deallocate-ip-addresses
JC-wk a1ca86a
Merge branch 'main' into deallocate-ip-addresses
JC-wk 6ebeb08
bump api version
3583506
Merge branch 'main' into deallocate-ip-addresses
JC-wk b32d4ef
changelog
48908ea
Merge branch 'main' into deallocate-ip-addresses
JC-wk fc9ba33
Copilot feedback
69f0b3e
remove spaces
2924a12
Merge branch 'main' into deallocate-ip-addresses
JC-wk 84c6915
Merge branch 'main' into deallocate-ip-addresses
JC-wk 88ba948
Merge branch 'main' into deallocate-ip-addresses
JC-wk b352c12
Merge branch 'main' into deallocate-ip-addresses
JC-wk e962d53
Bump version to 0.25.27
JC-wk 32c56a1
Merge branch 'main' into deallocate-ip-addresses
JC-wk ece05e3
Merge branch 'main' into deallocate-ip-addresses
JC-wk f1a6711
Merge branch 'main' into deallocate-ip-addresses
JC-wk 702f078
### Summary of Changes
232c088
copilot feedback
a622859
• Refactored AutoLockRenewer in deployment_status_updater.py to use…
1d65c72
1. **deployment_status_updater.py**:
bf72041
Add SERVICE_BUS_MAX_WAIT_TIME configuration and improve error handlin…
04be27d
Fix CosmosAccessConditionFailedError instantiation in tests for airlo…
ad7bdb6
Fix type casting for span attributes in DeploymentStatusUpdater and u…
9a08ecd
Merge branch 'main' into deallocate-ip-addresses
JC-wk f6b7e09
Merge branch 'main' into deallocate-ip-addresses
JC-wk 1ce7cb0
Handle workspace address cleanup failures
8ac5d24
Defer workspace address cleanup until upgrade
2711e28
Select the matching resource when freeing workspace address space
5d668e8
Mock workspace repository in deployment status tests
60e52b6
Require successful root step for workspace address cleanup
9e78958
standardize the deallocation of IP addresses for workspace services u…
a360697
Merge branch 'main' into deallocate-ip-addresses
JC-wk 9fb1eb3
CHANGELOG
JC-wk 6e71bb1
Fix address space cleanup handling for cascade uninstalls
b2d187f
Fix workspace address space removal payload and failure status handling
bdca9b2
Serialize workspace address allocation with active operations and res…
1732ec2
Serialize workspace mutations against active cleanup and ensure clean…
3586aac
Lock workspace from start via resourcePath, keep active status on ret…
0fc006d
Append fallback step before persisting status and treat address confl…
69dded3
Validate ownership before enqueue, make enqueue retryable, and handle…
624de53
revert service bus changes in favour of PR 4930
95e9305
Adjust delivery count handling for final cleanup in DeploymentStatusU…
4b2b20f
Guard completed address space cleanup against redelivered status mess…
9e8207a
Resolve cleanup redelivery, terminal failure, and concurrent workspac…
4ac97bf
Enhance deployment message handling with deterministic message IDs an…
JC-wk 7d830ec
Refactor workspace service operations and update delivery count handl…
JC-wk 9b2751f
Address review feedback on deduplication, delivery counting, and work…
JC-wk f94c4ea
Make cleanup dispatch idempotent in application and revert queue recr…
JC-wk 0d551dc
Enable duplicate detection on workspacequeue and bump core version to…
JC-wk 5722c2a
Handle cleanup dispatch idempotency in application and revert Service…
JC-wk 13ae073
Inject empty active-services mock for workspace_services_repo in depl…
JC-wk eaf6150
Address Copilot review on terminal-state guards, resource lookups, an…
JC-wk 45bf936
Enhance address space cleanup validation and improve deployment statu…
JC-wk 3d6371b
Implement ETag handling in Operation updates and enhance step merging…
JC-wk 148bd61
Address Copilot feedback on etag exclusion, template validation, and …
JC-wk 5770364
Correct delivery_count indexing in updater and update pipeline schema…
JC-wk ab99415
Roll back operations on dispatch failure and correct repository mocki…
JC-wk 5c1892f
Persist failure status on dispatch failure and restore 0-based final …
JC-wk 18d5faf
Fix terminal status mapping and missing resource failure persistence …
JC-wk c1ae6c5
Reduce comment verbosity and remove obvious comments across cleanup i…
JC-wk 24740e4
Resolve stale-status concurrency on ETag conflict and derive step fai…
JC-wk d940017
Refactor failure status handling and improve UUID validation in resou…
JC-wk 92a52d3
Refactor resource path handling to include cascading operations and a…
JC-wk 098f3c5
Enforce workspace lock on descendant mutating routes and preserve del…
JC-wk ae0608c
Acquire atomic workspace lease on operation admission and roll back a…
JC-wk 57facf6
Acquire workspace lease before resource mutations, keep lease ownersh…
JC-wk f32fe94
Reclaim orphaned workspace leases after bounded expiry and retry on c…
JC-wk c3cd999
Reconcile stale operations and use conditional lease release
JC-wk 340ed43
Merge branch 'main' into deallocate-ip-addresses
JC-wk f91b6cd
bump version
JC-wk 7265c8b
Address Copilot review on lease expiry, acquisition retry, and fail-c…
JC-wk 64d1671
Exclude terminal statuses in active ops query and require non-empty s…
JC-wk ce885d0
Extend lease expiry margin, keep lease during caller rollback, and se…
JC-wk 4efc650
Release lease on internal dispatch failures and serialize airlock ope…
JC-wk 7877eeb
Address Copilot review: conditional rollback, ETag delete check, and …
JC-wk 6248f86
Address Copilot review feedback on background tasks, lease retention,…
JC-wk 9acf41a
Retain lease on ambiguous dispatch, await airlock cleanup, and retry …
JC-wk 54440d6
Propagate rollback errors, preserve lease_retained on HTTPException, …
JC-wk a08268f
Address Copilot feedback: try-finally lease release, reconciled opera…
JC-wk 15f6787
Schedule review user resource deletion via BackgroundTasks to avoid H…
JC-wk ecc79b5
Use step resourceAction for stale step status and await uninstall in …
JC-wk ef5a1b6
Enhance error handling for CosmosAccessConditionFailedError
JC-wk f17e48d
Await airlock resource cleanup during review and cancellation
3530553
Improve lease retention, stale operation reconciliation, and review r…
e205c2e
Improve workspace lease handling and stale operation reconciliation
7ebff4e
Improve Airlock VM replacement and workspace lease cleanup
6e1af03
Merge branch 'main' into deallocate-ip-addresses
JC-wk 2865635
Bump API version to 0.26.10
2c96e1d
Merge branch 'deallocate-ip-addresses' of https://github.com/JC-wk/Az…
705d1bc
Improve Airlock resource cleanup and redeployment workflows
8596924
Improve Airlock workflow cleanup and lease handling
c983ac7
Improve Airlock redeployment recovery and workspace lease cleanup
f94474d
Merge branch 'main' into deallocate-ip-addresses
JC-wk 3e17a00
fix tests
4273197
Merge branch 'deallocate-ip-addresses' of https://github.com/JC-wk/Az…
3ed812e
Fix Airlock deletion sequencing and operation reconciliation
3022bda
Include operation ID in redeploy workflow ID
JC-wk ad6cefb
Serialize address space allocation with allocator leases
f0d0040
Serialize resource deletion and Airlock redeployment operations
25a9c7b
Preserve lease state and Airlock reviewer identity
609f49c
Fix Airlock redeployment workspace and retry handling
06acaf3
Improve Airlock workflow retries and lease handling
8e94364
Fix await usage in VM deployment function
JC-wk 8128e69
Reconcile expired workspace operations
6e33abb
Enhance Airlock workflow processing and improve operation reconciliat…
672526b
Improve address space lease and Airlock redeploy handling
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| __version__ = "0.26.9" | ||
| __version__ = "0.26.10" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.